[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: fixbug and extend partition function

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #1679: fixbug and extend partition function
URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r315966311
 
 

 ##########
 File path: fe/src/main/cup/sql_parser.cup
 ##########
 @@ -1515,6 +1521,15 @@ partition_key_desc ::=
     :}
     ;
 
+fixed_partition_key_desc ::=
+    LBRACKET string_list:keys RPAREN
+    {:
+        if (keys.size() != 2) {
 
 Review comment:
   I think the proper format is:
   `[("low1", "low2"), ("up1", "up2"))`
   
   And should also support :
   `[("low1", "low2", ..), ("up1"))`, and the default value should be filled with min value
   
   Do we support MAXVALUE?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org