You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/11 19:43:43 UTC
[GitHub] [spark] venkata91 commented on a change in pull request #33644: [SPARK-36419][CORE] Optionally move final aggregation in RDD.treeAggregate to executor
venkata91 commented on a change in pull request #33644:
URL: https://github.com/apache/spark/pull/33644#discussion_r687122613
##########
File path: project/MimaExcludes.scala
##########
@@ -104,6 +104,10 @@ object MimaExcludes {
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.shuffle.api.SingleSpillShuffleMapOutputWriter.transferMapSpillFile"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.shuffle.api.SingleSpillShuffleMapOutputWriter.transferMapSpillFile"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.shuffle.api.ShuffleMapOutputWriter.commitAllPartitions")
+
+ // [SPARK-36419][CORE] Optionally move final aggregation in RDD.treeAggregate to executor
+ ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.api.java.JavaRDDLike.treeAggregate")
Review comment:
I think we need to add
`ProblemFilters.exclude[DirectMissingMethodProblem("org.apache.spark.api.java.JavaRDDLike.treeAggregate")`
`ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.rdd.RDD.treeAggregate")`
##########
File path: core/src/test/java/test/org/apache/spark/JavaAPISuite.java
##########
@@ -541,7 +541,7 @@ public void treeAggregate() {
JavaRDD<Integer> rdd = sc.parallelize(Arrays.asList(-5, -4, -3, -2, -1, 1, 2, 3, 4), 10);
Function2<Integer, Integer, Integer> add = (a, b) -> a + b;
for (int depth = 1; depth <= 10; depth++) {
- int sum = rdd.treeAggregate(0, add, add, depth);
+ int sum = rdd.treeAggregate(0, add, add, depth, false);
Review comment:
nit: already the default value is `false` right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org