svn commit: r1006143 - /incubator/aries/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/proxy/Collaborator.java

[ma...@apache.org]

Author: mahrwald
Date: Sat Oct  9 12:25:04 2010
New Revision: 1006143

URL: http://svn.apache.org/viewvc?rev=1006143&view=rev
Log:
ARIES-443: Downgrade exception logging for main paths

Modified:
    incubator/aries/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/proxy/Collaborator.java

Modified: incubator/aries/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/proxy/Collaborator.java
URL: http://svn.apache.org/viewvc/incubator/aries/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/proxy/Collaborator.java?rev=1006143&r1=1006142&r2=1006143&view=diff
==============================================================================
--- incubator/aries/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/proxy/Collaborator.java (original)
+++ incubator/aries/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/proxy/Collaborator.java Sat Oct  9 12:25:04 2010
@@ -50,7 +50,6 @@ class Collaborator implements Invocation
 
     private transient List<Interceptor> interceptors = null;
     private transient ComponentMetadata cm = null;
-    private transient boolean sorted = false;
 
     Collaborator(ComponentMetadata cm, List<Interceptor> interceptors,
             final Callable<?> delegateObj) {
@@ -147,8 +146,8 @@ class Collaborator implements Invocation
                         calledInterceptors);
 
             } catch (Throwable e) {
-                // log the exception e
-                LOGGER.error("invoke", e);
+                // whether the the exception is an error is an application decision
+                LOGGER.debug("invoke", e);
 
                 // if we catch an exception we decide carefully which one to
                 // throw onwards
@@ -215,7 +214,7 @@ class Collaborator implements Invocation
                 se.interceptor.postCallWithReturn(cm, method, returnType, se
                         .getPreCallToken());
             } catch (Throwable t) {
-                LOGGER.error("postCallInterceptorWithReturn", t);
+                LOGGER.debug("postCallInterceptorWithReturn", t);
                 // propagate this to invoke ... further interceptors will be
                 // called via the postCallInterceptorWithException method
                 throw t;
@@ -231,7 +230,7 @@ class Collaborator implements Invocation
      * @param method
      *            : method
      * @param exception
-     *            : exception throwed
+     *            : exception thrown
      */
     private void postCallInterceptorWithException(ComponentMetadata cm,
             Method method, Throwable exception,
@@ -259,7 +258,7 @@ class Collaborator implements Invocation
 
     // info to store on interceptor stack during invoke
     private static class StackElement {
-        private Interceptor interceptor;
+        private final Interceptor interceptor;
         private Object preCallToken;
 
         private StackElement(Interceptor i) {