You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/26 15:14:42 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #17304: [improve][doc] sync Connection URLs section
tisonkun opened a new pull request, #17304:
URL: https://github.com/apache/pulsar/pull/17304
This closes #17303.
- [x] `doc`
cc @shibd @RobertIndie @Anonymitaet @momo-jun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #17304: [improve][doc] sync Connection URLs section
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17304:
URL: https://github.com/apache/pulsar/pull/17304#discussion_r956527035
##########
site2/docs/client-libraries-cpp.md:
##########
@@ -341,30 +341,24 @@ ${PULSAR_HOME}/pulsar-client-cpp/build/lib/Release/pulsar.dll
## Connection URLs
-To connect Pulsar using client libraries, you need to specify a Pulsar protocol URL.
+To connect to Pulsar using client libraries, you need to specify a [Pulsar protocol](developing-binary-protocol.md) URL.
-Pulsar protocol URLs are assigned to specific clusters, you can use the Pulsar URI scheme. The default port is `6650`. The following is an example for localhost.
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar` scheme. The following is an example of `localhost` with the default port `6650`:
```http
-
pulsar://localhost:6650
-
```
-In a Pulsar cluster in production, the URL looks as follows.
+If you have multiple brokers, separate `ip:port` by commas:
```http
-
-pulsar://pulsar.us-west.example.com:6650
-
+pulsar://localhost:6550,localhost:6651,localhost:6652
```
-If you use TLS authentication, you need to add `ssl`, and the default port is `6651`. The following is an example.
+If you use [TLS](security-tls-authentication.md) authentication, add `+ssl` in scheme:
Review Comment:
```suggestion
If you use [TLS](security-tls-authentication.md) authentication, add `+ssl` in the scheme:
```
It needs a definite article since it refers to the `pulsar` schema mentioned in line346.
5 more occurrences need an update too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #17304: [improve][doc] sync Connection URLs section
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #17304:
URL: https://github.com/apache/pulsar/pull/17304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17304: [improve][doc] sync Connection URLs section
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17304:
URL: https://github.com/apache/pulsar/pull/17304#discussion_r956549505
##########
site2/docs/client-libraries-dotnet.md:
##########
@@ -54,6 +54,28 @@ To install the Pulsar C# client library, following these steps:
```
+## Connection URLs
+
+To connect to Pulsar using client libraries, you need to specify a [Pulsar protocol](developing-binary-protocol.md) URL.
+
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar` scheme. The following is an example of `localhost` with the default port `6650`:
+
+```http
+pulsar://localhost:6650
+```
+
+If you have multiple brokers, separate `ip:port` by commas:
Review Comment:
```suggestion
If you have multiple brokers, separate `IP:port` by commas:
```
Capitalize proper nouns correctly. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.je5thtkj42cb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17304: [improve][doc] sync Connection URLs section
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17304:
URL: https://github.com/apache/pulsar/pull/17304#discussion_r956550435
##########
site2/docs/client-libraries-dotnet.md:
##########
@@ -54,6 +54,28 @@ To install the Pulsar C# client library, following these steps:
```
+## Connection URLs
+
+To connect to Pulsar using client libraries, you need to specify a [Pulsar protocol](developing-binary-protocol.md) URL.
+
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar` scheme. The following is an example of `localhost` with the default port `6650`:
+
+```http
+pulsar://localhost:6650
+```
+
+If you have multiple brokers, separate `ip:port` by commas:
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17304: [improve][doc] sync Connection URLs section
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17304:
URL: https://github.com/apache/pulsar/pull/17304#discussion_r956531713
##########
site2/docs/client-libraries-cpp.md:
##########
@@ -341,30 +341,24 @@ ${PULSAR_HOME}/pulsar-client-cpp/build/lib/Release/pulsar.dll
## Connection URLs
-To connect Pulsar using client libraries, you need to specify a Pulsar protocol URL.
+To connect to Pulsar using client libraries, you need to specify a [Pulsar protocol](developing-binary-protocol.md) URL.
-Pulsar protocol URLs are assigned to specific clusters, you can use the Pulsar URI scheme. The default port is `6650`. The following is an example for localhost.
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar` scheme. The following is an example of `localhost` with the default port `6650`:
```http
-
pulsar://localhost:6650
-
```
-In a Pulsar cluster in production, the URL looks as follows.
+If you have multiple brokers, separate `ip:port` by commas:
```http
-
-pulsar://pulsar.us-west.example.com:6650
-
+pulsar://localhost:6550,localhost:6651,localhost:6652
```
-If you use TLS authentication, you need to add `ssl`, and the default port is `6651`. The following is an example.
+If you use [TLS](security-tls-authentication.md) authentication, add `+ssl` in scheme:
Review Comment:
Updated. It's possible we find a place to describe all about the connection URLs format and leave only the simplest `pulsar://localhost:6650` in each client libraries document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17304: [improve][doc] sync Connection URLs section
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17304:
URL: https://github.com/apache/pulsar/pull/17304#discussion_r956531747
##########
site2/docs/client-libraries-cpp.md:
##########
@@ -341,30 +341,24 @@ ${PULSAR_HOME}/pulsar-client-cpp/build/lib/Release/pulsar.dll
## Connection URLs
-To connect Pulsar using client libraries, you need to specify a Pulsar protocol URL.
+To connect to Pulsar using client libraries, you need to specify a [Pulsar protocol](developing-binary-protocol.md) URL.
-Pulsar protocol URLs are assigned to specific clusters, you can use the Pulsar URI scheme. The default port is `6650`. The following is an example for localhost.
+You can assign Pulsar protocol URLs to specific clusters and use the `pulsar` scheme. The following is an example of `localhost` with the default port `6650`:
```http
-
pulsar://localhost:6650
-
```
-In a Pulsar cluster in production, the URL looks as follows.
+If you have multiple brokers, separate `ip:port` by commas:
```http
-
-pulsar://pulsar.us-west.example.com:6650
-
+pulsar://localhost:6550,localhost:6651,localhost:6652
```
-If you use TLS authentication, you need to add `ssl`, and the default port is `6651`. The following is an example.
+If you use [TLS](security-tls-authentication.md) authentication, add `+ssl` in scheme:
Review Comment:
Perhaps `developing-binary-protocol` or I will regard it as a basic concept. This can be a follow-up improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org