[GitHub] [doris-spark-connector] timey13 commented on a diff in pull request #45: [Fix] add tips for Mac OS users in case meeting getopt error

[GitBox <gi...@apache.org>]

timey13 commented on code in PR #45:
URL: https://github.com/apache/doris-spark-connector/pull/45#discussion_r933781782


##########
spark-doris-connector/build.sh:
##########
@@ -45,6 +45,17 @@ usage() {
   exit 1
 }
 
+# we use GNU enhanced version getopt command here for long option names, rather than the original version
+# determine the version of the getopt command before using
+getopt -T > /dev/null
+if [ $? -ne 4 ]; then
+  echo "
+    The GNU version of getopt command is required.
+    On Mac OS, you can use Homebrew to install gnu-getopt: brew install gnu-getopt, then set gnu-getopt as default getopt. Refernence: https://stackoverflow.com/questions/12152077/how-can-i-make-bash-deal-with-long-param-using-getopt-command-in-mac
+  "
+  exit 1
+fi
+

Review Comment:
   > When the build.sh is executed, "The GNU version of the getopt command is required" appears, and the execution will be exited. After installing gnu-getopt, the problem remains, and executing build.sh in the linux environment has no response.
   
   @caoliang-web I ignored the effect of 'set -eo pipefail' in last commit. Already fix this problem in the latest commit. Thank u for reviewing it again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org