You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/11/27 23:05:48 UTC
Review Request 69464: Made the `createTask` helper work for both v0
and v1 API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69464/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Till Toenshoff.
Bugs: MESOS-9419
https://issues.apache.org/jira/browse/MESOS-9419
Repository: mesos
Description
-------
The patched `createTask` helper originally uses the `slave_id` accessor,
which does not apply to the v1 API. This patch fixes this problem.
Diffs
-----
src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e
Diff: https://reviews.apache.org/r/69464/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69464: Made the `createTask` helper work for both
v0 and v1 API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69464/#review210929
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 27, 2018, 11:05 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69464/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2018, 11:05 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-9419
> https://issues.apache.org/jira/browse/MESOS-9419
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The patched `createTask` helper originally uses the `slave_id` accessor,
> which does not apply to the v1 API. This patch fixes this problem.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e
>
>
> Diff: https://reviews.apache.org/r/69464/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69464: Made the `createTask` helper work for both
v0 and v1 API.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69464/#review210915
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Nov. 27, 2018, 11:05 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69464/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2018, 11:05 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-9419
> https://issues.apache.org/jira/browse/MESOS-9419
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The patched `createTask` helper originally uses the `slave_id` accessor,
> which does not apply to the v1 API. This patch fixes this problem.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e
>
>
> Diff: https://reviews.apache.org/r/69464/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>