You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2010/05/18 23:37:22 UTC
[jira] Created: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Camel source jars should support source code attachment feature of eclipse ide in pde mode
------------------------------------------------------------------------------------------
Key: CAMEL-2734
URL: https://issues.apache.org/activemq/browse/CAMEL-2734
Project: Apache Camel
Issue Type: Improvement
Affects Versions: 2.2.0
Reporter: Christian Schneider
Fix For: 2.3.0
While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
Bundle-SymbolicName: org.apache.camel.camel-core.source
Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-2734:
---------------------------------------
Attachment: camel-core-2010-05-20.patch
Added a patch for the main pom that should cause all source jars to be updated with the required manifest entries. The only problem currently is that the version name of the bundle (should be 2.4.0-SNAPSHOT) is not correct for snapshots as 2.4-SNAPSHOT is used. But for releases this works well already.
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Fix For: 2.4.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59529#action_59529 ]
Willem Jiang commented on CAMEL-2734:
-------------------------------------
Hi Christian,
if you add the second install after the source:jar, you can find the source.jar is written to your local repository.
{code}
...
[INFO] Checking legal files in: camel-atom-2.4-SNAPSHOT.jar
[INFO] Checking legal files in: camel-atom-2.4-SNAPSHOT-sources.jar
[INFO] [install:install {execution: default-install}]
[INFO] Installing /Users/jiangning/work/camel/trunk/components/camel-atom/target/camel-atom-2.4-SNAPSHOT.jar to /Users/jiangning/.m2/repository/org/apache/camel/camel-atom/2.4-SNAPSHOT/camel-atom-2.4-SNAPSHOT.jar
[INFO] Installing /Users/jiangning/work/camel/trunk/components/camel-atom/target/camel-atom-2.4-SNAPSHOT-sources.jar to /Users/jiangning/.m2/repository/org/apache/camel/camel-atom/2.4-SNAPSHOT/camel-atom-2.4-SNAPSHOT-sources.jar
...
{code}
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2734) Camel source jars should
support source code attachment feature of eclipse ide in pde mode
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59458#action_59458 ]
Willem Jiang edited comment on CAMEL-2734 at 5/19/10 10:25 PM:
---------------------------------------------------------------
Don't worry, Christian, I will take care of it.
Actually, there is a variable("camel.osgi.version.clean") for you to get the "2.4.0.SNAPSHOT" when the project version is 2.4-SNAPSHOT.
was (Author: njiang):
Don't worry, Christian, I will take care of it.
Actually, there is a variable("camel.osgi.version.clean") for you to get the "2.4.0-SNAPSHOT" when the project version is 2.4-SNAPSHOT.
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.4.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59555#action_59555 ]
Willem Jiang commented on CAMEL-2734:
-------------------------------------
@Christian,
Thanks for the tip, I added the <Bundle-Version> entry into source manifest in revision 948651.
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59518#action_59518 ]
Christian Schneider commented on CAMEL-2734:
--------------------------------------------
When I build with "mvn -DskipTests clean source:jar install" the version is null in my Manifest. I also have no clue where the camel.osgi.version.clean is set. Is this variable set by hand when calling maven?
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59528#action_59528 ]
Christian Schneider commented on CAMEL-2734:
--------------------------------------------
Hi Willem,
this way the source jar is generated but then it is not written to the repository. I think we have to change the code that generates the properties to run earlier. Can you give me a hint where the antrun code is configured so I can take a look at it?
Greetings
Christian
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59553#action_59553 ]
Christian Schneider commented on CAMEL-2734:
--------------------------------------------
I think the problem with the source:jar call is that it is outside the normal build lifecycle. So the initialize phase where the properties are set is not called.
The following call works:
mvn initialize source:jar install
Btw. It is also possible to have the source plugin attach the source.jar to the installed artifacts everytime install is called. Do you think it would make sense to simply define this?
I have also found a minor problem with the source.jar Manifest we should fix. The Manifest should also contain a Bundle-Version. Could you add the following line to the <ManifestEntries>:
<Bundle-Version>${camel.osgi.version.clean}</Bundle-Version>
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2734.
--------------------------------
Resolution: Fixed
trunk: 946513
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.4.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59530#action_59530 ]
Willem Jiang commented on CAMEL-2734:
-------------------------------------
BTW, The properties generation configure is parent/pom.xml, antrun plugin section.
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-2734:
-----------------------------------
Assignee: Willem Jiang
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.4.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59458#action_59458 ]
Willem Jiang commented on CAMEL-2734:
-------------------------------------
Don't worry, Christian, I will take care of it.
Actually, there is a variable("camel.osgi.version.clean") for you to get the "2.4.0-SNAPSHOT" when the project version is 2.4-SNAPSHOT.
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Fix For: 2.4.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2734:
-------------------------------
Fix Version/s: 2.4.0
(was: 2.3.0)
Moving to 2.4 as we should *not* mess with the maven build at this late in the game for the 2.3 release.
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Fix For: 2.4.0
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59520#action_59520 ]
Willem Jiang commented on CAMEL-2734:
-------------------------------------
Hi Christian,
It looks like the source:jar only takes the properties which generate by antrun after the mvn install.
So "mvn -DskipTest clean install source:jar install" can do the trick for you.
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2734) Camel source jars should support
source code attachment feature of eclipse ide in pde mode
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea updated CAMEL-2734:
-----------------------------------
Fix Version/s: 2.3.0
(was: 2.4.0)
> Camel source jars should support source code attachment feature of eclipse ide in pde mode
> ------------------------------------------------------------------------------------------
>
> Key: CAMEL-2734
> URL: https://issues.apache.org/activemq/browse/CAMEL-2734
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse the same is currently very difficult when using the pde mode of eclipse. As this mode is the default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse. So I propose to add this header by default to all source artifacts created in the maven build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.