[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3538: [KYUUBI #3451] Implement GetInfo for JDBC engine

[GitBox <gi...@apache.org>]

Yikf commented on code in PR #3538:
URL: https://github.com/apache/incubator-kyuubi/pull/3538#discussion_r977207090


##########
externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/doris/OperationWithEngineSuite.scala:
##########
@@ -16,9 +16,47 @@
  */
 package org.apache.kyuubi.engine.jdbc.doris
 
+import org.apache.hive.service.rpc.thrift.{TGetInfoReq, TGetInfoType}
+
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.engine.jdbc.connection.ConnectionProvider
 import org.apache.kyuubi.operation.HiveJDBCTestHelper
 
 class OperationWithEngineSuite extends DorisOperationSuite with HiveJDBCTestHelper {
 
   override protected def jdbcUrl: String = jdbcConnectionUrl
+
+  test("Test for Jdbc engine getInfo") {
+    val metaData = ConnectionProvider.create(kyuubiConf).getMetaData

Review Comment:
   For reviewers: I didn't put this suite in `DorisOperationSuite ` because:
   
   To get the expected database medata, we need to create a separate classloader for `OperationWithServerSuite` to load `mysql-connector-java`, which seems redundant, and `OperationWithEngineSuite` is enough to test `getInfo`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org