You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by bu...@apache.org on 2010/04/18 09:20:44 UTC

svn commit: r935310 - in /ofbiz/trunk/applications/workeffort: webapp/workeffort/find/WorkEffortSearchOptions.ftl widget/WorkEffortCommEventForms.xml

Author: buscob
Date: Sun Apr 18 07:20:44 2010
New Revision: 935310

URL: http://svn.apache.org/viewvc?rev=935310&view=rev
Log:
A patch from Blas Rodriguez Somoza
OFBIZ-3682 - XHTML validation errors round 2 (workeffort)
https://issues.apache.org/jira/browse/OFBIZ-3682
XHTML validation errors

    * Unclosed tags
    * attributes without values (checked, selected, disabled, etc)
    * attribute values without "
    * Uppercase tags or attributes.
    * Unencoded ampersands in urls.

Other errors:

WorkEffortSearchOptions.ftl
Line 162: Input is not allowed directly inside table.

WorkEffortCommEventForms.xml
Line 59: hidden field in sort order before banner creates a visible empty table.

Modified:
    ofbiz/trunk/applications/workeffort/webapp/workeffort/find/WorkEffortSearchOptions.ftl
    ofbiz/trunk/applications/workeffort/widget/WorkEffortCommEventForms.xml

Modified: ofbiz/trunk/applications/workeffort/webapp/workeffort/find/WorkEffortSearchOptions.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/webapp/workeffort/find/WorkEffortSearchOptions.ftl?rev=935310&r1=935309&r2=935310&view=diff
==============================================================================
--- ofbiz/trunk/applications/workeffort/webapp/workeffort/find/WorkEffortSearchOptions.ftl (original)
+++ ofbiz/trunk/applications/workeffort/webapp/workeffort/find/WorkEffortSearchOptions.ftl Sun Apr 18 07:20:44 2010
@@ -159,8 +159,8 @@ under the License.
             </div>
           </td>
         </tr>
-        <input type="image" src="<@o...@ofbizContentUrl>" onClick="javascript:document.advToKeyWordSearchForm.submit();"/>
       </table>
+        <input type="image" src="<@o...@ofbizContentUrl>" onclick="javascript:document.advToKeyWordSearchForm.submit();"/>
     </form>
   </div>
 </div>

Modified: ofbiz/trunk/applications/workeffort/widget/WorkEffortCommEventForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/widget/WorkEffortCommEventForms.xml?rev=935310&r1=935309&r2=935310&view=diff
==============================================================================
--- ofbiz/trunk/applications/workeffort/widget/WorkEffortCommEventForms.xml (original)
+++ ofbiz/trunk/applications/workeffort/widget/WorkEffortCommEventForms.xml Sun Apr 18 07:20:44 2010
@@ -56,8 +56,8 @@ under the License.
         <field name="communicationEventId"><lookup target-form-name="LookupCommEvent"/></field>
         <field name="submitButton" title="${uiLabelMap.CommonAdd}" widget-style="buttontext"><submit button-type="text-link"/></field>
         <sort-order>
-            <sort-field name="workEffortId"/>
             <banner left-text-style="tabletext" left-text="${uiLabelMap.WorkEffortBanner3}"/>
+            <sort-field name="workEffortId"/>
             <sort-field name="communicationEventId"/>
             <banner left-text-style="tabletext" left-text="${uiLabelMap.WorkEffortBanner4}"/>
             <sort-field name="description"/>