You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Ben Mahler <be...@gmail.com> on 2015/04/15 20:58:23 UTC
Review Request 33233: Updated mesos library to 0.22.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33233/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs: AURORA-1276
https://issues.apache.org/jira/browse/AURORA-1276
Repository: aurora
Description
-------
This is needed to take advantage of explicit status update acknowledgements.
Diffs
-----
3rdparty/python/requirements.txt c23f98ca69197c400598c45b88c7c6415ffaf566
build.gradle d310e825c0372efe0b1fef02ad8e2a7b4901b74a
docs/deploying-aurora-scheduler.md 796d821726ac8d042b732ce8e3a195af34f647c4
examples/vagrant/provision-dev-cluster.sh 73cd7d7c0a88180763cf69accef3f77957f0625d
src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java f4214fb1c6a870d46efb937a2bbb8415acfda643
Diff: https://reviews.apache.org/r/33233/diff/
Testing
-------
Unit tests pass.
End-to-end tests require the following fix (via maxim):
```
diff --git a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
index 7736ff4..c93a478 100644
--- a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
+++ b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
@@ -40,8 +40,8 @@ exec $DIST_DIR/install/aurora-scheduler/bin/aurora-scheduler \
-mesos_master_address=zk://localhost:2181/mesos/master \
-serverset_path=/aurora/scheduler \
-native_log_zk_group_path=/aurora/replicated-log \
- -native_log_file_path=$AURORA_HOME/scheduler/db \
- -backup_dir=$AURORA_HOME/scheduler/backups \
+ -native_log_file_path=/var/db/aurora \
+ -backup_dir=/var/lib/aurora/backups \
-thermos_executor_path=$DIST_DIR/thermos_executor.pex \
-thermos_executor_flags="--announcer-enable --announcer-ensemble localhost:2181" \
-gc_executor_path=$DIST_DIR/gc_executor.pex \
```
Thanks,
Ben Mahler
Re: Review Request 33233: Updated mesos library to 0.22.0.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33233/#review80382
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On April 15, 2015, 10:42 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33233/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 10:42 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-1276
> https://issues.apache.org/jira/browse/AURORA-1276
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is needed to take advantage of explicit status update acknowledgements.
>
>
> Diffs
> -----
>
> 3rdparty/python/requirements.txt c23f98ca69197c400598c45b88c7c6415ffaf566
> build.gradle d310e825c0372efe0b1fef02ad8e2a7b4901b74a
> docs/deploying-aurora-scheduler.md 796d821726ac8d042b732ce8e3a195af34f647c4
> examples/vagrant/provision-dev-cluster.sh 73cd7d7c0a88180763cf69accef3f77957f0625d
> src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java f4214fb1c6a870d46efb937a2bbb8415acfda643
>
> Diff: https://reviews.apache.org/r/33233/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
> End-to-end tests require the following fix (via maxim):
>
> ```
> diff --git a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> index 7736ff4..c93a478 100644
> --- a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> +++ b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> @@ -40,8 +40,8 @@ exec $DIST_DIR/install/aurora-scheduler/bin/aurora-scheduler \
> -mesos_master_address=zk://localhost:2181/mesos/master \
> -serverset_path=/aurora/scheduler \
> -native_log_zk_group_path=/aurora/replicated-log \
> - -native_log_file_path=$AURORA_HOME/scheduler/db \
> - -backup_dir=$AURORA_HOME/scheduler/backups \
> + -native_log_file_path=/var/db/aurora \
> + -backup_dir=/var/lib/aurora/backups \
> -thermos_executor_path=$DIST_DIR/thermos_executor.pex \
> -thermos_executor_flags="--announcer-enable --announcer-ensemble localhost:2181" \
> -gc_executor_path=$DIST_DIR/gc_executor.pex \
> ```
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 33233: Updated mesos library to 0.22.0.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33233/#review80736
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 15, 2015, 10:42 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33233/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 10:42 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-1276
> https://issues.apache.org/jira/browse/AURORA-1276
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is needed to take advantage of explicit status update acknowledgements.
>
>
> Diffs
> -----
>
> 3rdparty/python/requirements.txt c23f98ca69197c400598c45b88c7c6415ffaf566
> build.gradle d310e825c0372efe0b1fef02ad8e2a7b4901b74a
> docs/deploying-aurora-scheduler.md 796d821726ac8d042b732ce8e3a195af34f647c4
> examples/vagrant/provision-dev-cluster.sh 73cd7d7c0a88180763cf69accef3f77957f0625d
> src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java f4214fb1c6a870d46efb937a2bbb8415acfda643
>
> Diff: https://reviews.apache.org/r/33233/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
> End-to-end tests require the following fix (via maxim):
>
> ```
> diff --git a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> index 7736ff4..c93a478 100644
> --- a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> +++ b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> @@ -40,8 +40,8 @@ exec $DIST_DIR/install/aurora-scheduler/bin/aurora-scheduler \
> -mesos_master_address=zk://localhost:2181/mesos/master \
> -serverset_path=/aurora/scheduler \
> -native_log_zk_group_path=/aurora/replicated-log \
> - -native_log_file_path=$AURORA_HOME/scheduler/db \
> - -backup_dir=$AURORA_HOME/scheduler/backups \
> + -native_log_file_path=/var/db/aurora \
> + -backup_dir=/var/lib/aurora/backups \
> -thermos_executor_path=$DIST_DIR/thermos_executor.pex \
> -thermos_executor_flags="--announcer-enable --announcer-ensemble localhost:2181" \
> -gc_executor_path=$DIST_DIR/gc_executor.pex \
> ```
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 33233: Updated mesos library to 0.22.0.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33233/
-----------------------------------------------------------
(Updated April 15, 2015, 10:42 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Added end-to-end test fix as a dependency.
Bugs: AURORA-1276
https://issues.apache.org/jira/browse/AURORA-1276
Repository: aurora
Description
-------
This is needed to take advantage of explicit status update acknowledgements.
Diffs
-----
3rdparty/python/requirements.txt c23f98ca69197c400598c45b88c7c6415ffaf566
build.gradle d310e825c0372efe0b1fef02ad8e2a7b4901b74a
docs/deploying-aurora-scheduler.md 796d821726ac8d042b732ce8e3a195af34f647c4
examples/vagrant/provision-dev-cluster.sh 73cd7d7c0a88180763cf69accef3f77957f0625d
src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java f4214fb1c6a870d46efb937a2bbb8415acfda643
Diff: https://reviews.apache.org/r/33233/diff/
Testing
-------
Unit tests pass.
End-to-end tests require the following fix (via maxim):
```
diff --git a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
index 7736ff4..c93a478 100644
--- a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
+++ b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
@@ -40,8 +40,8 @@ exec $DIST_DIR/install/aurora-scheduler/bin/aurora-scheduler \
-mesos_master_address=zk://localhost:2181/mesos/master \
-serverset_path=/aurora/scheduler \
-native_log_zk_group_path=/aurora/replicated-log \
- -native_log_file_path=$AURORA_HOME/scheduler/db \
- -backup_dir=$AURORA_HOME/scheduler/backups \
+ -native_log_file_path=/var/db/aurora \
+ -backup_dir=/var/lib/aurora/backups \
-thermos_executor_path=$DIST_DIR/thermos_executor.pex \
-thermos_executor_flags="--announcer-enable --announcer-ensemble localhost:2181" \
-gc_executor_path=$DIST_DIR/gc_executor.pex \
```
Thanks,
Ben Mahler
Re: Review Request 33233: Updated mesos library to 0.22.0.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33233/#review80255
-----------------------------------------------------------
Ship it!
Master (10e75fc) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 15, 2015, 6:58 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33233/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 6:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-1276
> https://issues.apache.org/jira/browse/AURORA-1276
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is needed to take advantage of explicit status update acknowledgements.
>
>
> Diffs
> -----
>
> 3rdparty/python/requirements.txt c23f98ca69197c400598c45b88c7c6415ffaf566
> build.gradle d310e825c0372efe0b1fef02ad8e2a7b4901b74a
> docs/deploying-aurora-scheduler.md 796d821726ac8d042b732ce8e3a195af34f647c4
> examples/vagrant/provision-dev-cluster.sh 73cd7d7c0a88180763cf69accef3f77957f0625d
> src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java f4214fb1c6a870d46efb937a2bbb8415acfda643
>
> Diff: https://reviews.apache.org/r/33233/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
> End-to-end tests require the following fix (via maxim):
>
> ```
> diff --git a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> index 7736ff4..c93a478 100644
> --- a/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> +++ b/examples/vagrant/upstart/aurora-scheduler-kerberos.conf
> @@ -40,8 +40,8 @@ exec $DIST_DIR/install/aurora-scheduler/bin/aurora-scheduler \
> -mesos_master_address=zk://localhost:2181/mesos/master \
> -serverset_path=/aurora/scheduler \
> -native_log_zk_group_path=/aurora/replicated-log \
> - -native_log_file_path=$AURORA_HOME/scheduler/db \
> - -backup_dir=$AURORA_HOME/scheduler/backups \
> + -native_log_file_path=/var/db/aurora \
> + -backup_dir=/var/lib/aurora/backups \
> -thermos_executor_path=$DIST_DIR/thermos_executor.pex \
> -thermos_executor_flags="--announcer-enable --announcer-ensemble localhost:2181" \
> -gc_executor_path=$DIST_DIR/gc_executor.pex \
> ```
>
>
> Thanks,
>
> Ben Mahler
>
>