You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/01/09 07:58:09 UTC
zeppelin git commit: [MINOR] fix: DON'T clean in npm run dev cause it
does nothing
Repository: zeppelin
Updated Branches:
refs/heads/master 24ca17b7d -> b4b011dc6
[MINOR] fix: DON'T clean in npm run dev cause it does nothing
### What is this PR for?
Removed clean task in npm run dev because webpack-dev-server uses in-memory build :)
This was annoying since you have to build again after executing `npm run dev` which deleting the `zeppelin-web/dist` directory
### What type of PR is it?
[Bug Fix]
### Todos
Fixed at once
### What is the Jira issue?
MINOR
### How should this be tested?
1. Execute `npm run build && npm run dev`
2. Check whether`dist` directory exists or not
### Screenshots (if appropriate)
None
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #1869 from 1ambda/fix/DON'T-clean-while-run-dev and squashes the following commits:
79d876c [1ambda] fix: DON'T clean in npm run dev
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/b4b011dc
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/b4b011dc
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/b4b011dc
Branch: refs/heads/master
Commit: b4b011dc6ac63008394fa5d2a090b00c1d3c36a5
Parents: 24ca17b
Author: 1ambda <1a...@gmail.com>
Authored: Sun Jan 8 14:38:12 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Sun Jan 8 23:58:01 2017 -0800
----------------------------------------------------------------------
zeppelin-web/package.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/b4b011dc/zeppelin-web/package.json
----------------------------------------------------------------------
diff --git a/zeppelin-web/package.json b/zeppelin-web/package.json
index 555165f..ed1cb16 100644
--- a/zeppelin-web/package.json
+++ b/zeppelin-web/package.json
@@ -10,7 +10,7 @@
"postinstall": "bower install --silent && grunt googlefonts",
"prebuild": "npm-run-all clean",
"build": "grunt pre-webpack-dist && webpack && grunt post-webpack-dist",
- "predev": "npm-run-all clean && grunt pre-webpack-dev",
+ "predev": "grunt pre-webpack-dev",
"dev:server": "webpack-dev-server --hot",
"dev:watch": "grunt watch-webpack-dev",
"dev": "npm-run-all --parallel dev:server dev:watch",