You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/02/26 08:58:13 UTC

[GitHub] [camel] davsclaus commented on a change in pull request #7040: CAMEL-17474: camel-core - set transacted when copying exchange in mul…

davsclaus commented on a change in pull request #7040:
URL: https://github.com/apache/camel/pull/7040#discussion_r815288253



##########
File path: core/camel-core-processor/src/main/java/org/apache/camel/processor/MulticastProcessor.java
##########
@@ -910,6 +910,7 @@ protected Integer getExchangeIndex(Exchange exchange) {
         for (Processor processor : processors) {
             // copy exchange, and do not share the unit of work
             Exchange copy = processorExchangeFactory.createCorrelatedCopy(exchange, false);
+            copy.adapt(ExtendedExchange.class).setTransacted(exchange.isTransacted());

Review comment:
       There would be other EIPs such as split etc that would need something similar. Maybe we can set the transacted in the createCorrelatedCopy (however wiretap EIP would need to set it to false as the tap exchange should not be transacted. 
   
   So can you look at which other EIPs that use the createCorrelatedCopy API and build unit tests like you have for multicast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org