You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2026/07/07 22:01:36 UTC
(superset) branch master updated: fix(a11y): add aria-label to notification method remove button (#41850)
This is an automated email from the ASF dual-hosted git repository.
eschutho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new d9e1f34527b fix(a11y): add aria-label to notification method remove button (#41850)
d9e1f34527b is described below
commit d9e1f34527be013ec6fcce423ff131aff586c9c6
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Tue Jul 7 15:01:30 2026 -0700
fix(a11y): add aria-label to notification method remove button (#41850)
---
superset-frontend/src/features/alerts/components/NotificationMethod.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/features/alerts/components/NotificationMethod.tsx b/superset-frontend/src/features/alerts/components/NotificationMethod.tsx
index 72b19c2cbc2..edd8cef7619 100644
--- a/superset-frontend/src/features/alerts/components/NotificationMethod.tsx
+++ b/superset-frontend/src/features/alerts/components/NotificationMethod.tsx
@@ -465,12 +465,12 @@ export const NotificationMethod: FunctionComponent<NotificationMethodProps> = ({
loading={methodOptionsLoading}
/>
{index !== 0 && !!onRemove ? (
- // eslint-disable-next-line jsx-a11y/control-has-associated-label
<span
role="button"
tabIndex={0}
className="delete-button"
onClick={() => onRemove(index)}
+ aria-label={t('Remove notification method')}
>
<Icons.DeleteOutlined iconSize="l" />
</span>