[jira] [Commented] (CXF-8087) unstable test environment caused by accessing system property without cleanup

["Colm O hEigeartaigh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902803#comment-16902803 ] 

Colm O hEigeartaigh commented on CXF-8087:
------------------------------------------

Could you submit a pull request for this issue?

> unstable test environment caused by accessing system property without cleanup
> -----------------------------------------------------------------------------
>
>                 Key: CXF-8087
>                 URL: https://issues.apache.org/jira/browse/CXF-8087
>             Project: CXF
>          Issue Type: Test
>          Components: JAX-RS
>    Affects Versions: 3.3.2
>            Reporter: zi peng
>            Priority: Minor
>              Labels: test
>
> _JAXRSclientServerWebSocketTest_ is inherited by several tests. In one of its child tests( i.e. _JAXRSClientServerWebSocketNoAtmosphereTest_), system property is set to true in the test fixture.  However, none test cases or fixture reset the modified system property after the completion of a test run. 
> Result: test results may become flaky and unstable in multiple test runs
>  
> {code:java}
> public class JAXRSClientServerWebSocketNoAtmosphereTest extends JAXRSClientServerWebSocketTest {	
>     @BeforeClass
>     public static void startServers() throws Exception {
> 	System.setProperty("org.apache.cxf.transport.websocket.atmosphere.disabled", "true");
> 	AbstractResourceInfo.clearAllMaps();
> 	assertTrue("server did not launch correctly", launchServer(new BookServerWebSocket(PORT)));
> 	createStaticBus();
>     }
> 	
>     @AfterClass
>     public static void cleanup() {
> 	//System.clearProperty("org.apache.cxf.transport.websocket.atmosphere.disabled");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)