[GitHub] [hadoop] huxinqiu commented on a diff in pull request #5151: HADOOP-18533. RPC Client performance improvement

[GitBox <gi...@apache.org>]

huxinqiu commented on code in PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#discussion_r1027073201


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -392,7 +394,7 @@ private class Connection extends Thread {
     private IOException closeException; // close reason
 
     private final Thread rpcRequestThread;
-    private final SynchronousQueue<Pair<Call, ResponseBuffer>> rpcRequestQueue =
+    private final SynchronousQueue<Pair<Call, Object>> rpcRequestQueue =

Review Comment:
   Because for WritableRpcEngine, there is no easy way to calculate the size of request parameters, ResponseBuffer is a better choice, so Object represents ResponseBuffer or RpcProtobufRequestWithHeader.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org