You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shant Hovsepian (Code Review)" <ge...@cloudera.org> on 2020/04/17 19:38:33 UTC
[Impala-ASF-CR] Fix formatting of HBaseScanNode explain output.
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15749
Change subject: Fix formatting of HBaseScanNode explain output.
......................................................................
Fix formatting of HBaseScanNode explain output.
In the case with more than one hbase predicate the indentation level
wasn't correctly formatted in the explain string.
Instead of:
| | 13:SCAN HBASE [default.dimension d]
| | hbase filters:
| | d:foo EQUAL '1'
| | d:bar EQUAL '2'
| | d:baz EQUAL '3'
| | predicate:
This was produced:
| | 13:SCAN HBASE [default.dimension d]
| | hbase filters:
d:foo EQUAL '1'
d:bar EQUAL '2'
d:baz EQUAL '3'
| | predicate:
Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
---
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/hbase.test
2 files changed, 19 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/15749/1
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5760/
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 14:16:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5788/
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 08:37:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5968/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 23:19:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 3: Code-Review+2
Thanks for creating the JIRA. It will easy backport processes.
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 09:02:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 01:18:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 3:
Test failed due to IMPALA-9729. Rerun the GVO.
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 03:17:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix formatting of HBaseScanNode explain output.
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: Fix formatting of HBaseScanNode explain output.
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
The fix looks good to me.
http://gerrit.cloudera.org:8080/#/c/15749/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15749/1//COMMIT_MSG@7
PS1, Line 7: Fix formatting of HBaseScanNode explain output.
Since this is not an urgent hot-fix, could you create a JIRA for this?
http://gerrit.cloudera.org:8080/#/c/15749/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java:
http://gerrit.cloudera.org:8080/#/c/15749/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@591
PS1, Line 591: + "'" + filter.filter_constant + "'"
nit: could you move this to the previous line?
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Apr 2020 00:39:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Fix formatting of HBaseScanNode explain output.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: Fix formatting of HBaseScanNode explain output.
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/5821/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Apr 2020 20:20:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15749/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15749/1//COMMIT_MSG@7
PS1, Line 7: Fix formatting of HBaseScanNode explain output.
> Since this is not an urgent hot-fix, could you create a JIRA for this?
Done
http://gerrit.cloudera.org:8080/#/c/15749/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java:
http://gerrit.cloudera.org:8080/#/c/15749/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@591
PS1, Line 591: + "'" + filter.filter_constant + "'"
> nit: could you move this to the previous line?
Agreed will do, but this was the formatted enforced by clang-format.
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 22:40:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 03:18:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5788/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 03:19:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
IMPALA-9727: Fix HBaseScanNode explain formatting
In the case with more than one hbase predicate the indentation level
wasn't correctly formatted in the explain string.
Instead of:
| | 13:SCAN HBASE [default.dimension d]
| | hbase filters:
| | d:foo EQUAL '1'
| | d:bar EQUAL '2'
| | d:baz EQUAL '3'
| | predicate:
This was produced:
| | 13:SCAN HBASE [default.dimension d]
| | hbase filters:
d:foo EQUAL '1'
d:bar EQUAL '2'
d:baz EQUAL '3'
| | predicate:
Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Reviewed-on: http://gerrit.cloudera.org:8080/15749
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/hbase.test
2 files changed, 18 insertions(+), 14 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 6
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5760/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 09:03:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 06:37:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15749 )
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5809/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 01:18:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9727: Fix HBaseScanNode explain formatting
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Thomas Tauber-Marshall, Fang-Yu Rao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15749
to look at the new patch set (#2).
Change subject: IMPALA-9727: Fix HBaseScanNode explain formatting
......................................................................
IMPALA-9727: Fix HBaseScanNode explain formatting
In the case with more than one hbase predicate the indentation level
wasn't correctly formatted in the explain string.
Instead of:
| | 13:SCAN HBASE [default.dimension d]
| | hbase filters:
| | d:foo EQUAL '1'
| | d:bar EQUAL '2'
| | d:baz EQUAL '3'
| | predicate:
This was produced:
| | 13:SCAN HBASE [default.dimension d]
| | hbase filters:
d:foo EQUAL '1'
d:bar EQUAL '2'
d:baz EQUAL '3'
| | predicate:
Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
---
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/hbase.test
2 files changed, 18 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/15749/2
--
To view, visit http://gerrit.cloudera.org:8080/15749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30fad791408a1f7e35e9b3f2e6cb4958952dd567
Gerrit-Change-Number: 15749
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>