You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "X-czh (via GitHub)" <gi...@apache.org> on 2024/01/18 13:54:32 UTC
[PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh opened a new pull request, #24133:
URL: https://github.com/apache/flink/pull/24133
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Support source parallelism setting for DataGen connector.
## Brief change log
- Add SOURCE_PARALLELISM into DataGenConnectorOptions and pass it to planner
- Update docs, introducing scan.parallelism
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) yes
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #24133:
URL: https://github.com/apache/flink/pull/24133#issuecomment-1899531944
@libenchao Could you help review it after #24128 is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #24133:
URL: https://github.com/apache/flink/pull/24133#issuecomment-1902132296
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24133:
URL: https://github.com/apache/flink/pull/24133#issuecomment-1911798162
@X-czh thanks for discovering the compilation error that was merged into `master`. Could you merge the hotfix commit separately from the bigger change of this PR? The hotfix commit doesn't need to wait for CI to pass and would enable `master` to be stable again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24133:
URL: https://github.com/apache/flink/pull/24133#issuecomment-1911845153
Ah I see, thanks for the pointer. I approved and merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on code in PR #24133:
URL: https://github.com/apache/flink/pull/24133#discussion_r1467171751
##########
docs/content/docs/connectors/table/datagen.md:
##########
@@ -270,6 +270,13 @@ Connector Options
<td>Long</td>
<td>The total number of rows to emit. By default, the table is unbounded.</td>
</tr>
+ <tr>
+ <td><h5>scan.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Long</td>
Review Comment:
Thanks for catching this. I'll fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #24133:
URL: https://github.com/apache/flink/pull/24133#issuecomment-1911838497
@XComp Thanks for the notice. We've already prepared another separate PR: #24200 on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on code in PR #24133:
URL: https://github.com/apache/flink/pull/24133#discussion_r1467163104
##########
docs/content/docs/connectors/table/datagen.md:
##########
@@ -270,6 +270,13 @@ Connector Options
<td>Long</td>
<td>The total number of rows to emit. By default, the table is unbounded.</td>
</tr>
+ <tr>
+ <td><h5>scan.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Long</td>
Review Comment:
Actually it's defined as `int` in the code.
##########
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java:
##########
@@ -581,6 +588,27 @@ void testWrongTypes() {
anyCauseMatches("Could not parse value 'Wrong' for key 'fields.f0.start'"));
}
+ @Test
+ void testWithParallelism() {
Review Comment:
In FLINK-33263, we've introduced a way to verify that the transformation, could you also add a test based on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on code in PR #24133:
URL: https://github.com/apache/flink/pull/24133#discussion_r1467174161
##########
docs/content/docs/connectors/table/datagen.md:
##########
@@ -270,6 +270,13 @@ Connector Options
<td>Long</td>
<td>The total number of rows to emit. By default, the table is unbounded.</td>
</tr>
+ <tr>
+ <td><h5>scan.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Long</td>
Review Comment:
Fixed in the new commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao closed pull request #24133: [FLINK-33264][table] Support source parallelism setting for DataGen connector
URL: https://github.com/apache/flink/pull/24133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24133:
URL: https://github.com/apache/flink/pull/24133#issuecomment-1898552816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce0c1fb08207d66bb5693b1311bb03d7ba1fda3d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ce0c1fb08207d66bb5693b1311bb03d7ba1fda3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce0c1fb08207d66bb5693b1311bb03d7ba1fda3d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on PR #24133:
URL: https://github.com/apache/flink/pull/24133#issuecomment-1899537774
> @libenchao Could you help review it after #24128 is merged?
I assigned it to myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on code in PR #24133:
URL: https://github.com/apache/flink/pull/24133#discussion_r1467171607
##########
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java:
##########
@@ -581,6 +588,27 @@ void testWrongTypes() {
anyCauseMatches("Could not parse value 'Wrong' for key 'fields.f0.start'"));
}
+ @Test
+ void testWithParallelism() {
Review Comment:
I've already included an IT case in `DataGeneratorConnectorITCase#testWithParallelism` where the physical execution plan is checked, would that be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org