You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2020/02/11 02:09:00 UTC
[jira] [Comment Edited] (CASSANDRA-12995) update hppc dependency to
0.7
[ https://issues.apache.org/jira/browse/CASSANDRA-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034079#comment-17034079 ]
Ekaterina Dimitrova edited comment on CASSANDRA-12995 at 2/11/20 2:08 AM:
--------------------------------------------------------------------------
Latest update ([~gus] you might consider also for Lucene and Solr):
As of [HPPC-125 |https://issues.carrot2.org/browse/HPPC-125] LongHashSet#equals() method assumes the same exact implementation class, that's why our unit test doesn't work anymore:
[https://github.com/carrotsearch/hppc/blob/master/hppc/src/main/templates/com/carrotsearch/hppc/KTypeHashSet.java#L407]
The change has been documented here:
[https://github.com/carrotsearch/hppc/blob/master/CHANGES.txt#L114-L116]
Further to this unit test, I will have to inspect also the rest of the Cassandra code for usage of this method and do corrections accordingly, if needed.
was (Author: e.dimitrova):
[~gus] Latest update you might consider also for Lucene and Solr:
As of [HPPC-125 |https://issues.carrot2.org/browse/HPPC-125] LongHashSet#equals() method assumes the same exact implementation class, that's why our unit test doesn't work anymore:
[https://github.com/carrotsearch/hppc/blob/master/hppc/src/main/templates/com/carrotsearch/hppc/KTypeHashSet.java#L407]
The change has been documented here:
[https://github.com/carrotsearch/hppc/blob/master/CHANGES.txt#L114-L116]
Further to this unit test, I will have to inspect also the rest of the Cassandra code for usage of this method and do corrections accordingly, if needed.
> update hppc dependency to 0.7
> -----------------------------
>
> Key: CASSANDRA-12995
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12995
> Project: Cassandra
> Issue Type: Improvement
> Components: Dependencies, Packaging
> Reporter: Tomas Repik
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Labels: easyfix
> Fix For: 4.0
>
> Attachments: Screen Shot 2020-01-29 at 11.14.30 AM.png, Screen Shot 2020-01-29 at 11.20.39 AM.png, Screen Shot 2020-01-29 at 11.20.47 AM.png, cassandra-3.11.0-hppc.patch
>
>
> Cassandra 3.11.0 is about to be included in Fedora. There are some tweaks to the sources we need to do in order to successfully build it. Cassandra depends on hppc 0.5.4, but In Fedora we have the newer version 0.7.1 Upstream released even newer version 0.7.2. I attached a patch updating cassandra sources to depend on the 0.7.1 hppc sources. It should be also compatible with the newest upstream version. The only actual changes are the removal of Open infix in class names. The issue was discussed in here: https://bugzilla.redhat.com/show_bug.cgi?id=1340876 Please consider updating.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org