[whimsy] branch master updated: Replace with library method

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 47813ec  Replace with library method
47813ec is described below

commit 47813ecf14e53afd4d68d626eeaffa72f3a613b4
Author: Sebb <se...@apache.org>
AuthorDate: Tue Jun 9 22:10:02 2020 +0100

    Replace with library method
---
 www/officers/acreq.cgi | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/www/officers/acreq.cgi b/www/officers/acreq.cgi
index 81b2942..92d70a2 100755
--- a/www/officers/acreq.cgi
+++ b/www/officers/acreq.cgi
@@ -352,11 +352,8 @@ _html do
 
                     # and commit the change ...
                     _h2 'Commit messages'
-                    # TODO replace with library method see WHIMSY-103
-                    rc = _.system ['svn',
-                      ['--username', env.user, '--password', env.password],
-                      'commit', File.join(tmpdir, 'new-account-reqs.txt'),
-                      '-m', "#{@user} account request by #{user.id} for #{requestor}"]
+                    rc = ASF::SVN.svn_('commit', File.join(tmpdir, 'new-account-reqs.txt'), _,
+                          {args: ['--message', "#{@user} account request by #{user.id} for #{requestor}"], env: env})
 
                     if rc == 0
                       mail.deliver!