You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/01 02:05:24 UTC

[GitHub] cloud-fan commented on a change in pull request #23606: [SPARK-26666][SQL] Support DSv2 overwrite and dynamic partition overwrite.

cloud-fan commented on a change in pull request #23606: [SPARK-26666][SQL] Support DSv2 overwrite and dynamic partition overwrite.
URL: https://github.com/apache/spark/pull/23606#discussion_r252912696
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/sources/filters.scala
 ##########
 @@ -218,3 +218,23 @@ case class StringEndsWith(attribute: String, value: String) extends Filter {
 case class StringContains(attribute: String, value: String) extends Filter {
   override def references: Array[String] = Array(attribute)
 }
+
+/**
+ * A filter that always evaluates to `true`.
+ */
+case class AlwaysTrue() extends Filter {
 
 Review comment:
   why it's a case class instead of object?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org