[jira] [Commented] (DRILL-5696) change default compiler strategy

["Jinfeng Ni (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108069#comment-16108069 ] 

Jinfeng Ni commented on DRILL-5696:
-----------------------------------

Can you provide more specific detail about the comparison you did? What agg expression do you use in your query? What is the compile time with JDK 8 / Janino, respectively?  What is the execution time for the agg operator? Those detail will give people clearer idea whether we should set JDK 8 as the default compiler. 


> change default compiler strategy
> --------------------------------
>
>                 Key: DRILL-5696
>                 URL: https://issues.apache.org/jira/browse/DRILL-5696
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Codegen
>    Affects Versions: 1.9.0, 1.10.0, 1.11.0
>            Reporter: weijie.tong
>
> at our production ,when we have more than 20 agg expression, the  compile time is high using the default janino.  but when changed to  jdk compiler,we gain fewer compile time than the janino one. Our product jdk version is 1.8. 
> So the default one should be JDK , if user's jdk version is upper than 1.7. We should add another check condition to the ClassCompilerSelector.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)