[jira] [Commented] (MESOS-5885) max_executors_per_agent does not take effect on mesos docker executor

["Jie Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390341#comment-15390341 ] 

Jie Yu commented on MESOS-5885:
-------------------------------

This is unfortunately a bug in Mesos and a tech debt that we need to fix. Currently, master only keeps track of those executors of an agent that has an executorInfo (i.e., custom executors). For command tasks, master does not keep track of that in `slave->executors`. I think a true fix is to keep track of executorInfo for command tasks as well so that the whole code base is consistent on the hierarchy (slave -> frameworks -> executors -> tasks), especially when we want to introduce Pod like concept in Mesos.

A short term fix might be loop through `slave->tasks` as well and account for command tasks as well.

> max_executors_per_agent does not take effect on mesos docker executor
> ---------------------------------------------------------------------
>
>                 Key: MESOS-5885
>                 URL: https://issues.apache.org/jira/browse/MESOS-5885
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.27.3, 0.28.2, 1.0.0
>         Environment: centos 7.2
>            Reporter: Qi Feng
>              Labels: mesosphere
>
> I build mesos-1.0.0-rc2 with network isolator in centos 7.2. And try to set max_executors_per_agent=10 to test if docker task would be limited in 10 on every mesos agent. In fact, my case is launching 40 tasks (0.1core 0.1M mem each) on three different agent machine, and both agent launched more than 10 tasks.
> I found mesos master hold executor data in a haspmap, and the key is ExecutorID.
> https://github.com/apache/mesos/blob/1.0.x/src/master/master.hpp#L306
> https://github.com/apache/mesos/blob/1.0.x/src/master/master.cpp#L5747
> Then I get state.json from mesos master to looking for any executor information. Then I found executer_id is empty string in taskInfo json. Is there any relation between the empty executor id and max_executors_per_agent issue?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)