You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "Joe Skora (JIRA)" <ji...@apache.org> on 2015/07/06 16:40:04 UTC
[jira] [Comment Edited] (NIFI-679) InvokeHTTP - Add support for
basic authentication
[ https://issues.apache.org/jira/browse/NIFI-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615071#comment-14615071 ]
Joe Skora edited comment on NIFI-679 at 7/6/15 2:39 PM:
--------------------------------------------------------
I noticed that the patch ([-NIFI-749-|https://issues.apache.org/jira/browse/NIFI-749]) for the unit test EOL issue included additional changes to finalize variables in some of the tests.
In the interest of getting it "more right" next time...
1. Are the preferred patterns for source format, patterns like local mutability, etc. documented anywhere? (Apologies if I missed it.)
2. Is it ok to include unrelated code cleanup in a patch or is it preferred for those types of edits to be separated into a separate "cleanup" commit?
was (Author: jskora):
I noticed that the patch for the unit test EOL issue included additional changes to finalize variables in some of the tests.
In the interest of getting it "more right" next time...
1. Are the preferred patterns for source format, patterns like local mutability, etc. documented anywhere? (Apologies if I missed it.)
2. Is it ok to include unrelated code cleanup in a patch or is it preferred for those types of edits to be separated into a separate "cleanup" commit?
> InvokeHTTP - Add support for basic authentication
> -------------------------------------------------
>
> Key: NIFI-679
> URL: https://issues.apache.org/jira/browse/NIFI-679
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Gilman
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: nifi-679.patch
>
>
> InvokeHTTP should optionally support username/password for web services that do not employ certificate based authentication.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)