[GitHub] [jmeter] vlsi commented on a change in pull request #677: Align ssl props / Enable setting cipher suite (WIP)

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r748906691



##########
File path: src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/Proxy.java
##########
@@ -89,6 +89,19 @@
     private static final String SSLCONTEXT_PROTOCOL =
         JMeterUtils.getPropDefault("proxy.ssl.protocol", "TLS"); // $NON-NLS-1$ $NON-NLS-2$
 
+    private static final String PROTOCOL_LIST =
+            JMeterUtils.getPropDefault("https.socket.protocols", ""); // $NON-NLS-1$ $NON-NLS-2$
+
+    private static final String CIPHER_SUITE_LIST =
+            JMeterUtils.getPropDefault("https.cipherSuites", ""); // $NON-NLS-1$ $NON-NLS-2$
+
+    private static final String[] SUPPORTED_PROTOCOL_LIST =
+            PROTOCOL_LIST.isEmpty() ?
+                    null: PROTOCOL_LIST.split(" "); // $NON-NLS-1$

Review comment:
       What do you think if trim the value first, and then split with `\\s+` pattern? In other words, allow multiple whitespace as a separator




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org