You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonded94 (via GitHub)" <gi...@apache.org> on 2024/11/20 14:30:46 UTC
[PR] Expose 'parquet::record::make_row' function call to users [arrow-rs]
jonded94 opened a new pull request, #6762:
URL: https://github.com/apache/arrow-rs/pull/6762
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/6761
# Rationale for this change
`parquet::record::make_row` was not exposed to users, leaving them no option to create `parquet::record::Row` objects themselfes.
# What changes are included in this PR?
`parquet::record::make_row` is exposed publicy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Expose 'parquet::record::make_row' function call to users [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #6762: Expose 'parquet::record::make_row' function call to users
URL: https://github.com/apache/arrow-rs/pull/6762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Expose 'parquet::record::make_row' function call to users [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl commented on PR #6762:
URL: https://github.com/apache/arrow-rs/pull/6762#issuecomment-2489084442
If we want to allow creating `Row`s outside the module, would it be better to add a public `new()` to the `Row` API? (And maybe get rid of `make_row`?)
cc @alamb @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Expose 'parquet::record::make_row' function call to users [arrow-rs]
Posted by "jonded94 (via GitHub)" <gi...@apache.org>.
jonded94 commented on PR #6762:
URL: https://github.com/apache/arrow-rs/pull/6762#issuecomment-2489467058
Implemented an alternative PR which does remove `make_row` entirely and creates a `new` method. https://github.com/apache/arrow-rs/pull/6763
Let me know whichever approach you prefer :) This unfortunately currently blocks a bit my work (I have some manual steps where I explicitly modify & create new `Row` instances and can't do that right now), so I'm happy to have quick progress here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org