You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/06/04 16:04:27 UTC
Re: Review Request 33850: libprocess: use standard macros for
compiler and vendor detection
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86602
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/33850/#comment138661>
s/Mesos/libprocess/
- Benjamin Hindman
On May 15, 2015, 4:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 4:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
>
>
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876
> 3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION
> 3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33850/diff/
>
>
> Testing
> -------
>
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 GCC toolchain is still rejected as too old.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 33850: libprocess: use standard macros for
compiler and vendor detection
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote:
> >
Just a heads up, you went from the +2 indentation in this file to +4 when you moved stuff around. I fixed it for you, but please keep the style consistent in the future, thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86602
-----------------------------------------------------------
On May 15, 2015, 4:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 4:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
>
>
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876
> 3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION
> 3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33850/diff/
>
>
> Testing
> -------
>
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 GCC toolchain is still rejected as too old.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 33850: libprocess: use standard macros for
compiler and vendor detection
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/configure.ac, line 694
> > <https://reviews.apache.org/r/33850/diff/2/?file=950418#file950418line694>
> >
> > s/Mesos/libprocess/
I took care of this fix for you James before committing. Thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86602
-----------------------------------------------------------
On May 15, 2015, 4:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 4:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
>
>
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876
> 3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION
> 3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33850/diff/
>
>
> Testing
> -------
>
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 GCC toolchain is still rejected as too old.
>
>
> Thanks,
>
> James Peach
>
>