You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/02/11 05:32:23 UTC
[GitHub] [hudi] lamber-ken commented on a change in pull request #2567: [HUDI-1612] Fix write test flakiness in StreamWriteITCase
lamber-ken commented on a change in pull request #2567:
URL: https://github.com/apache/hudi/pull/2567#discussion_r574259291
##########
File path: hudi-flink/src/test/java/org/apache/hudi/operator/utils/TestData.java
##########
@@ -149,6 +156,51 @@ public static void checkWrittenData(
}
}
+ /**
+ * Checks the source data are written as expected.
+ *
+ * <p>Note: Replace it with the Flink reader when it is supported.
+ *
+ * @param basePath The file base to check, should be a directory
+ * @param expected The expected results mapping, the key should be the partition path
+ */
+ public static void checkWrittenFullData(
Review comment:
> @lamber-ken It seems this mechanism looks more reasonable. So, a question is this method can fully replace `checkWrittenData`?
No, because the tests in StreamWriteFunctionTest can use `TestData#checkWrittenData` to check data for each checkpoint manually, like
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org