You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/11 09:17:21 UTC

[GitHub] [apisix] nic-chen commented on pull request #3222: fix: support grpc proxy with upstream_id support

nic-chen commented on pull request #3222:
URL: https://github.com/apache/apisix/pull/3222#issuecomment-757776471


   @yongboy 
   
   I think the key points are:
   https://github.com/apache/apisix/pull/3224/files#diff-7439ffe94cc4bcad12066d5d83f6c1004b8e9b3ff5097b645fa7c700eb3b3743R26-R559
   
   https://github.com/apache/apisix/pull/3224/files#diff-c6a774885b1f6ef5f4cb5d027eb59cf81d6065588e3e7c5620814b3d0819ec1eR61
   
   
   We don't need to maintain `access_phase` function for each protocol, we only need to call the corresponding additional function as needed at the end of `http_access_phase`.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org