You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/05/08 22:44:16 UTC
Re: Review Request 33514: Wired up --allocator flag in master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/
-----------------------------------------------------------
(Updated May 8, 2015, 8:44 p.m.)
Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Addressed Vinod's comment.
Bugs: MESOS-2597
https://issues.apache.org/jira/browse/MESOS-2597
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
Diff: https://reviews.apache.org/r/33514/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Checked the whole pipeline works with a modularized allocator. The allocator is HierarchicalDRF packed into a library: https://github.com/rukletsov/mesos-modules/tree/master/external-allocator
Master and slave have been pointed to an allocator module:
```
./bin/mesos-master.sh --work_dir=m/work --modules=file://<path>/external-allocator.json --allocator=ExternalAllocatorModule
./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work
```
Slave successfully registers, its resources are offered to a simple task:
```
./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test
```
Thanks,
Alexander Rukletsov
Re: Review Request 33514: Wired up --allocator flag in master.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83764
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33513, 33514]
All tests passed.
- Mesos ReviewBot
On May 14, 2015, 1:23 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33514/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 1:23 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33514/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
> Checked the whole pipeline works with a modularized allocator. The allocator is HierarchicalDRF packed into a library: https://github.com/rukletsov/mesos-modules/tree/master/external-allocator
>
> Master and slave have been pointed to an allocator module:
> ```
> ./bin/mesos-master.sh --work_dir=m/work --modules=file://<path>/external-allocator.json --allocator=ExternalAllocatorModule
> ./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work
> ```
>
> Slave successfully registers, its resources are offered to a simple task:
> ```
> ./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 33514: Wired up --allocator flag in master.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/
-----------------------------------------------------------
(Updated May 14, 2015, 1:23 p.m.)
Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-2597
https://issues.apache.org/jira/browse/MESOS-2597
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
Diff: https://reviews.apache.org/r/33514/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Checked the whole pipeline works with a modularized allocator. The allocator is HierarchicalDRF packed into a library: https://github.com/rukletsov/mesos-modules/tree/master/external-allocator
Master and slave have been pointed to an allocator module:
```
./bin/mesos-master.sh --work_dir=m/work --modules=file://<path>/external-allocator.json --allocator=ExternalAllocatorModule
./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work
```
Slave successfully registers, its resources are offered to a simple task:
```
./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test
```
Thanks,
Alexander Rukletsov
Re: Review Request 33514: Wired up --allocator flag in master.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83095
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33513, 33514]
All tests passed.
- Mesos ReviewBot
On May 8, 2015, 8:44 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33514/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 8:44 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33514/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
> Checked the whole pipeline works with a modularized allocator. The allocator is HierarchicalDRF packed into a library: https://github.com/rukletsov/mesos-modules/tree/master/external-allocator
>
> Master and slave have been pointed to an allocator module:
> ```
> ./bin/mesos-master.sh --work_dir=m/work --modules=file://<path>/external-allocator.json --allocator=ExternalAllocatorModule
> ./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work
> ```
>
> Slave successfully registers, its resources are offered to a simple task:
> ```
> ./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 33514: Wired up --allocator flag in master.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On May 8, 2015, 8:58 p.m., Joerg Schad wrote:
> > src/master/flags.cpp, line 351
> > <https://reviews.apache.org/r/33514/diff/4/?file=953424#file953424line351>
> >
> > Could you add this flag to the documentation
> > http://mesos.apache.org/documentation/latest/configuration/
I have a ticket for the doc update (https://issues.apache.org/jira/browse/MESOS-2596), I've expanded it to capture your suggestion. Thanks!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83085
-----------------------------------------------------------
On May 8, 2015, 8:44 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33514/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 8:44 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33514/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
> Checked the whole pipeline works with a modularized allocator. The allocator is HierarchicalDRF packed into a library: https://github.com/rukletsov/mesos-modules/tree/master/external-allocator
>
> Master and slave have been pointed to an allocator module:
> ```
> ./bin/mesos-master.sh --work_dir=m/work --modules=file://<path>/external-allocator.json --allocator=ExternalAllocatorModule
> ./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work
> ```
>
> Slave successfully registers, its resources are offered to a simple task:
> ```
> ./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 33514: Wired up --allocator flag in master.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On May 8, 2015, 8:58 p.m., Joerg Schad wrote:
> > Please add to documentation
After that Ship it!
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83085
-----------------------------------------------------------
On May 8, 2015, 8:44 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33514/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 8:44 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33514/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
> Checked the whole pipeline works with a modularized allocator. The allocator is HierarchicalDRF packed into a library: https://github.com/rukletsov/mesos-modules/tree/master/external-allocator
>
> Master and slave have been pointed to an allocator module:
> ```
> ./bin/mesos-master.sh --work_dir=m/work --modules=file://<path>/external-allocator.json --allocator=ExternalAllocatorModule
> ./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work
> ```
>
> Slave successfully registers, its resources are offered to a simple task:
> ```
> ./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 33514: Wired up --allocator flag in master.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83085
-----------------------------------------------------------
Please add to documentation
src/master/flags.cpp
<https://reviews.apache.org/r/33514/#comment133957>
Could you add this flag to the documentation
http://mesos.apache.org/documentation/latest/configuration/
- Joerg Schad
On May 8, 2015, 8:44 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33514/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 8:44 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33514/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
> Checked the whole pipeline works with a modularized allocator. The allocator is HierarchicalDRF packed into a library: https://github.com/rukletsov/mesos-modules/tree/master/external-allocator
>
> Master and slave have been pointed to an allocator module:
> ```
> ./bin/mesos-master.sh --work_dir=m/work --modules=file://<path>/external-allocator.json --allocator=ExternalAllocatorModule
> ./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work
> ```
>
> Slave successfully registers, its resources are offered to a simple task:
> ```
> ./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>