You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/10 18:04:42 UTC
[GitHub] [airflow] morrme opened a new pull request #14179: Issue 14097
morrme opened a new pull request #14179:
URL: https://github.com/apache/airflow/pull/14179
This PR fixes the issue described in [Typo in Sensor: GCSObjectsWtihPrefixExistenceSensor (should be GCSObjectsWithPrefixExistenceSensor)](https://github.com/apache/airflow/issues/14097)
Closes #14097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #14179:
URL: https://github.com/apache/airflow/pull/14179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] morrme commented on pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
morrme commented on pull request #14179:
URL: https://github.com/apache/airflow/pull/14179#issuecomment-777284005
> Unfortunately tests fail :(
@potiuk
Yes 💔 ... this is related to the changes made in the `deprecated_classes` file. I am still looking into what the correct change should have been.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #14179:
URL: https://github.com/apache/airflow/pull/14179#discussion_r574627852
##########
File path: tests/always/test_project_structure.py
##########
@@ -220,7 +220,7 @@ class TestGoogleProviderProjectStructure(unittest.TestCase):
'airflow.providers.google.cloud.operators.compute.ComputeEngineBaseOperator',
'airflow.providers.google.cloud.sensors.gcs.GCSObjectExistenceSensor',
'airflow.providers.google.cloud.sensors.gcs.GCSObjectUpdateSensor',
- 'airflow.providers.google.cloud.sensors.gcs.GCSObjectsWtihPrefixExistenceSensor',
+ 'airflow.providers.google.cloud.sensors.gcs.GCSObjectsWithPrefixExistenceSensor',
Review comment:
```suggestion
'airflow.providers.google.cloud.sensors.gcs.GCSObjectsWithPrefixExistenceSensor',
'airflow.providers.google.cloud.sensors.gcs.GCSObjectsWtihPrefixExistenceSensor',
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14179:
URL: https://github.com/apache/airflow/pull/14179#issuecomment-777009950
[The Workflow run](https://github.com/apache/airflow/actions/runs/555756150) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14179:
URL: https://github.com/apache/airflow/pull/14179#issuecomment-776918300
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14179:
URL: https://github.com/apache/airflow/pull/14179#issuecomment-776919403
[The Workflow run](https://github.com/apache/airflow/actions/runs/555535933) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14179:
URL: https://github.com/apache/airflow/pull/14179#issuecomment-777272272
Unfortunately tests fail :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14179: Correct typo in Sensor: GCSObjectsWtihPrefixExistenceSensor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14179:
URL: https://github.com/apache/airflow/pull/14179#issuecomment-777083442
[The Workflow run](https://github.com/apache/airflow/actions/runs/556066803) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org