You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/13 13:09:26 UTC
[GitHub] [shardingsphere] ThanoshanMV opened a new pull request, #16799: Add SQLServer REVERT Statement
ThanoshanMV opened a new pull request, #16799:
URL: https://github.com/apache/shardingsphere/pull/16799
For #6478
Changes proposed in this pull request:
- Add SQLServer [REVERT](https://docs.microsoft.com/en-us/sql/t-sql/statements/revert-transact-sql?view=sql-server-ver15) statement.
- Add test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on a diff in pull request #16799: Add SQLServer REVERT Statement
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on code in PR #16799:
URL: https://github.com/apache/shardingsphere/pull/16799#discussion_r850078852
##########
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/statement/impl/SQLServerDCLStatementSQLVisitor.java:
##########
@@ -353,4 +355,10 @@ public ASTNode visitSetUser(final SetUserContext ctx) {
}
return result;
}
+
+ @Override
+ public ASTNode visitRevert(final RevertContext ctx) {
+ SQLServerRevertStatement result = new SQLServerRevertStatement();
+ return result;
Review Comment:
Thank you @strongduanmu. I've made changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #16799: Add SQLServer REVERT Statement
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #16799:
URL: https://github.com/apache/shardingsphere/pull/16799#discussion_r849988807
##########
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/statement/impl/SQLServerDCLStatementSQLVisitor.java:
##########
@@ -353,4 +355,10 @@ public ASTNode visitSetUser(final SetUserContext ctx) {
}
return result;
}
+
+ @Override
+ public ASTNode visitRevert(final RevertContext ctx) {
+ SQLServerRevertStatement result = new SQLServerRevertStatement();
+ return result;
Review Comment:
@ThanoshanMV `return new SQLServerRevertStatement()` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16799: Add SQLServer REVERT Statement
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16799:
URL: https://github.com/apache/shardingsphere/pull/16799#issuecomment-1098514852
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16799?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16799](https://codecov.io/gh/apache/shardingsphere/pull/16799?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43a56e3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/05dc0a81390fe27ea9c11130d6ead152c9d1cee6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05dc0a8) will **increase** coverage by `0.14%`.
> The diff coverage is `64.28%`.
```diff
@@ Coverage Diff @@
## master #16799 +/- ##
============================================
+ Coverage 60.48% 60.63% +0.14%
- Complexity 2125 2127 +2
============================================
Files 3410 3415 +5
Lines 51144 51237 +93
Branches 8763 8776 +13
============================================
+ Hits 30936 31065 +129
+ Misses 17608 17558 -50
- Partials 2600 2614 +14
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../infra/yaml/config/pojo/YamlRootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9wb2pvL1lhbWxSb290Q29uZmlndXJhdGlvbi5qYXZh) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...re/driver/api/ShardingSphereDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9hcGkvU2hhcmRpbmdTcGhlcmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ource/ShardingSpherePipelineDataSourceCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9jb25maWcvZGF0YXNvdXJjZS9TaGFyZGluZ1NwaGVyZVBpcGVsaW5lRGF0YVNvdXJjZUNyZWF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ShardingSpherePipelineDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL2RhdGFzb3VyY2UvY29uZmlnL2ltcGwvU2hhcmRpbmdTcGhlcmVQaXBlbGluZURhdGFTb3VyY2VDb25maWd1cmF0aW9uLmphdmE=) | `51.85% <0.00%> (ø)` | |
| [...tement/sqlserver/dcl/SQLServerRevertStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvc3Fsc2VydmVyL2RjbC9TUUxTZXJ2ZXJSZXZlcnRTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../api/yaml/YamlShardingSphereDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9hcGkveWFtbC9ZYW1sU2hhcmRpbmdTcGhlcmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `50.00% <50.00%> (ø)` | |
| [...e/spring/boot/ShardingSphereAutoConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvYm9vdC9TaGFyZGluZ1NwaGVyZUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `66.66% <50.00%> (ø)` | |
| [...mespace/parser/DataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctbmFtZXNwYWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvbmFtZXNwYWNlL3BhcnNlci9EYXRhU291cmNlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `88.09% <66.66%> (-2.15%)` | :arrow_down: |
| [...gsphere/spring/boot/schema/DatabaseNameSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1pbmZyYS9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXN0YXJ0ZXItaW5mcmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L3NjaGVtYS9EYXRhYmFzZU5hbWVTZXR0ZXIuamF2YQ==) | `83.33% <80.00%> (ø)` | |
| [...jdbc/core/datasource/ShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ1NwaGVyZURhdGFTb3VyY2UuamF2YQ==) | `94.73% <92.30%> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/shardingsphere/pull/16799/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16799?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16799?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9d0ee5a...43a56e3](https://codecov.io/gh/apache/shardingsphere/pull/16799?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #16799: Add SQLServer REVERT Statement
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #16799:
URL: https://github.com/apache/shardingsphere/pull/16799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org