You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/16 20:35:58 UTC
[jira] [Work logged] (TS-5056) Implement nonrecoverable error
mechanism
[ https://issues.apache.org/jira/browse/TS-5056?focusedWorklogId=32126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32126 ]
ASF GitHub Bot logged work on TS-5056:
--------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/16 20:35
Start Date: 16/Nov/16 20:35
Worklog Time Spent: 10m
Work Description: GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1224
TS-5056 Implement nonrecoverable error mechanism
Change `Emergency()` to terminate the current process with status
code UNRECOVERABLE_EXIT.
Also change traffic_manager to listen for the UNRECOVERABLE_EXIT
status code. If heard, then TM will not try to restart TS from
that point forward.
This was designed so that traffic_server could call Emergency(..)
in the event of a nonrecoverable error such as a bad config file.
No amount of TS rebooting will fix a bad config, so we might as well
have TM wait for human intervention.
Note that if traffic_cop or traffic_manager calls Emergency(),
nothing totally unexpected will happen since the only visible change
from this patch is the status code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-5056
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1224
----
commit 43048cbf07325475e7a8d96ddaf13f872942b3e4
Author: Daniel Xu <dl...@yahoo.com>
Date: 2016-11-16T20:21:27Z
TS-5056 Implement nonrecoverable error mechanism
Change `Emergency()` to terminate the current process with status
code UNRECOVERABLE_EXIT.
Also change traffic_manager to listen for the UNRECOVERABLE_EXIT
status code. If heard, then TM will not try to restart TS from
that point forward.
This was designed so that traffic_server could call Emergency(..)
in the event of a nonrecoverable error such as a bad config file.
No amount of TS rebooting will fix a bad config, so we might as well
have TM wait for human intervention.
Note that if traffic_cop or traffic_manager calls Emergency(),
nothing totally unexpected will happen since the only visible change
from this patch is the status code.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 32126)
Time Spent: 10m
Remaining Estimate: 0h
> Implement nonrecoverable error mechanism
> ----------------------------------------
>
> Key: TS-5056
> URL: https://issues.apache.org/jira/browse/TS-5056
> Project: Traffic Server
> Issue Type: Improvement
> Components: Manager
> Reporter: Daniel Xu
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There should be a mechanism for {{traffic_server}} to signal to {{traffic_manager}} that {{traffic_server}} cannot be recovered with any amount of restarting.
> For example, if TS sees a bad log file, then no amount of restarting will fix TS. Thus, it would be better for TM to just sit tight and wait for human intervention.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)