You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/09 08:58:39 UTC
[GitHub] zentol commented on a change in pull request #7346:
[FLINK-11134][rest] Do not log stacktrace handled exceptions
zentol commented on a change in pull request #7346: [FLINK-11134][rest] Do not log stacktrace handled exceptions
URL: https://github.com/apache/flink/pull/7346#discussion_r246301325
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java
##########
@@ -160,28 +160,46 @@ protected void respondAsLeader(ChannelHandlerContext ctx, RoutedRequest routedRe
final FileUploads finalUploadedFiles = uploadedFiles;
requestProcessingFuture
.whenComplete((Void ignored, Throwable throwable) -> {
- inFlightRequestTracker.deregisterRequest();
- cleanupFileUploads(finalUploadedFiles);
+ if (throwable != null) {
+ handleException(ExceptionUtils.stripCompletionException(throwable), ctx, httpRequest);
+ }
+ finalizeRequestProcessing(finalUploadedFiles);
Review comment:
I've made changes to ensure that we finalize the request after the error response was sent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services