You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/01/26 15:16:42 UTC
Review Request 65351: Reordered roles in Web UI to display them
alphabetically by default.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-8495
https://issues.apache.org/jira/browse/MESOS-8495
Repository: mesos
Description
-------
Use the alphabetical order of the name of the roles by
default to display their hierarchy straightforwardly.
Diffs
-----
src/webui/master/static/js/app.js 463c563cd121e881f7d137123534a047c5e420d2
src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
Diff: https://reviews.apache.org/r/65351/diff/1/
Testing
-------
```
$ bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log' --weights="example=42,example/a=2" --registry=in_memory
```
UI before patch when viewing the roles tab:
UI by default after patch:
Thanks,
Armand Grillet
Re: Review Request 65351: Reordered roles in Web UI to display them
alphabetically by default.
Posted by Armand Grillet <ag...@mesosphere.io>.
> On Jan. 27, 2018, 2:22 a.m., Benjamin Mahler wrote:
> > Isn't this just doing reverse alphabetical?
> >
> > z
> > z/z
> > z/b
> > z/a
> > b
> > a
> > a/b
> > a/a
> >
> > Ideally we would have:
> >
> > a
> > a/z
> > a/b
> > b
> > z
> > z/a
> > z/b
> > z/z
With the patch it is alphabetical:
```
a
a/b
a/z
b
z
z/a
z/b
z/z
```
The first image in the "Testing Done" part is before the patch (i.e. reverse alphabetical). Check the second image to see the UI after applying the patch.
- Armand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/#review196382
-----------------------------------------------------------
On Jan. 26, 2018, 3:16 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65351/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 3:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8495
> https://issues.apache.org/jira/browse/MESOS-8495
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use the alphabetical order of the name of the roles by
> default to display their hierarchy straightforwardly.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 463c563cd121e881f7d137123534a047c5e420d2
> src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
>
>
> Diff: https://reviews.apache.org/r/65351/diff/1/
>
>
> Testing
> -------
>
> ```
> $ bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log' --weights="example=42,example/a=2" --registry=in_memory
> ```
> UI before patch when viewing the roles tab:
> 
> UI by default after patch:
> 
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65351: Reordered roles in Web UI to display them
alphabetically by default.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/#review196382
-----------------------------------------------------------
Isn't this just doing reverse alphabetical?
z
z/z
z/b
z/a
b
a
a/b
a/a
Ideally we would have:
a
a/z
a/b
b
z
z/a
z/b
z/z
- Benjamin Mahler
On Jan. 26, 2018, 3:16 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65351/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 3:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8495
> https://issues.apache.org/jira/browse/MESOS-8495
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use the alphabetical order of the name of the roles by
> default to display their hierarchy straightforwardly.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 463c563cd121e881f7d137123534a047c5e420d2
> src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
>
>
> Diff: https://reviews.apache.org/r/65351/diff/1/
>
>
> Testing
> -------
>
> ```
> $ bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log' --weights="example=42,example/a=2" --registry=in_memory
> ```
> UI before patch when viewing the roles tab:
> 
> UI by default after patch:
> 
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65351: Reordered roles in Web UI to display them
alphabetically by default.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/#review196455
-----------------------------------------------------------
Ship it!
src/webui/master/static/js/app.js
Line 276 (original), 276 (patched)
<https://reviews.apache.org/r/65351/#comment276110>
Does true represent descending? Seems we should comment this for the reader.
- Benjamin Mahler
On Jan. 26, 2018, 3:16 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65351/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 3:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8495
> https://issues.apache.org/jira/browse/MESOS-8495
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use the alphabetical order of the name of the roles by
> default to display their hierarchy straightforwardly.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 463c563cd121e881f7d137123534a047c5e420d2
> src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
>
>
> Diff: https://reviews.apache.org/r/65351/diff/1/
>
>
> Testing
> -------
>
> ```
> $ bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log' --weights="example=42,example/a=2" --registry=in_memory
> ```
> UI before patch when viewing the roles tab:
> 
> UI by default after patch:
> 
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65351: Reordered roles in Web UI to display them
alphabetically by default.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/#review196362
-----------------------------------------------------------
PASS: Mesos patch 65351 was successfully built and tested.
Reviews applied: `['65351']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65351
- Mesos Reviewbot Windows
On Jan. 26, 2018, 3:16 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65351/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 3:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8495
> https://issues.apache.org/jira/browse/MESOS-8495
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use the alphabetical order of the name of the roles by
> default to display their hierarchy straightforwardly.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 463c563cd121e881f7d137123534a047c5e420d2
> src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
>
>
> Diff: https://reviews.apache.org/r/65351/diff/1/
>
>
> Testing
> -------
>
> ```
> $ bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log' --weights="example=42,example/a=2" --registry=in_memory
> ```
> UI before patch when viewing the roles tab:
> 
> UI by default after patch:
> 
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65351: Reordered roles in Web UI to display them
alphabetically by default.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/#review196357
-----------------------------------------------------------
PASS: Mesos patch 65351 was successfully built and tested.
Reviews applied: `['65351']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65351
- Mesos Reviewbot Windows
On Jan. 26, 2018, 3:16 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65351/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 3:16 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8495
> https://issues.apache.org/jira/browse/MESOS-8495
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use the alphabetical order of the name of the roles by
> default to display their hierarchy straightforwardly.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 463c563cd121e881f7d137123534a047c5e420d2
> src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
>
>
> Diff: https://reviews.apache.org/r/65351/diff/1/
>
>
> Testing
> -------
>
> ```
> $ bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' --log_dir='/tmp/master1-log' --weights="example=42,example/a=2" --registry=in_memory
> ```
> UI before patch when viewing the roles tab:
> 
> UI by default after patch:
> 
>
>
> Thanks,
>
> Armand Grillet
>
>