You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/05/16 14:37:48 UTC
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Hello Joe McDonnell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15933
to review the following change.
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
IMPALA-9731 adopted the CDP version of many Hadoop dependencies.
This patch moves the Avro and Parquet Java components to their CDP
versions so that they are aligned with the other Hadoop components.
Test: Ran tests successfully in core mode.
Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
---
M bin/impala-config.sh
M fe/pom.xml
M impala-parent/pom.xml
M testdata/pom.xml
4 files changed, 31 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/15933/1
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jun 2020 04:12:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6085/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 May 2020 15:30:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
IMPALA-9731 adopted the CDP version of many Hadoop dependencies.
This patch moves the Avro and Parquet Java components to their CDP
versions so that they are aligned with the other Hadoop components.
Test: Ran tests successfully in core mode.
Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Reviewed-on: http://gerrit.cloudera.org:8080/15933
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
M impala-parent/pom.xml
M testdata/pom.xml
4 files changed, 25 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5976/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 22:53:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15933
to look at the new patch set (#2).
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
IMPALA-9731 adopted the CDP version of many Hadoop dependencies.
This patch moves the Avro and Parquet Java components to their CDP
versions so that they are aligned with the other Hadoop components.
Test: Ran tests successfully in core mode.
Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
---
M bin/impala-config.sh
M fe/pom.xml
M impala-parent/pom.xml
M testdata/pom.xml
4 files changed, 25 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/15933/2
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
This looks good to me. See my comment about the *_URL env variables.
http://gerrit.cloudera.org:8080/#/c/15933/1/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/15933/1/bin/impala-config.sh@223
PS1, Line 223: export CDP_AVRO_JAVA_URL=${CDP_AVRO_JAVA_URL-}
Nit: The *_URL env variables are used by bootstrap_toolchain.py. If we aren't downloading anything (i.e. this is maven-only), then you only need the version and can omit the URL variables.
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 18:19:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6258/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 22:51:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 22:53:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 )
Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Carry +2 from Joe after removing the unneeded _URL shell variables. Again a core mode build was successful.
http://gerrit.cloudera.org:8080/#/c/15933/1/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/15933/1/bin/impala-config.sh@223
PS1, Line 223: export CDP_HIVE_SOURCE_URL=${CDP_HIVE_SOURCE_U
> Nit: The *_URL env variables are used by bootstrap_toolchain.py. If we aren
Done
--
To view, visit http://gerrit.cloudera.org:8080/15933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c7c5832b5ba53a00b098642f6c64616eb944bd
Gerrit-Change-Number: 15933
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 22:22:13 +0000
Gerrit-HasComments: Yes