You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/06/30 13:51:34 UTC

[GitHub] spark pull request #18488: [SPARK-21255][SQL] Fixed NPE when creating encode...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18488#discussion_r125043648
  
    --- Diff: sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/EnumEncoderSuite.java ---
    @@ -0,0 +1,32 @@
    +package org.apache.spark.sql.catalyst;
    --- End diff --
    
    (Copy the copyright header you see in other files)
    Or, it looks like Encoders-related tests are otherwise all in JavaDatasetSuite. That may be a better place anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org