You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "thurka (via GitHub)" <gi...@apache.org> on 2023/03/08 13:29:28 UTC
[GitHub] [netbeans] thurka opened a new pull request, #5629: LSP: Fix Delete action in context menu
thurka opened a new pull request, #5629:
URL: https://github.com/apache/netbeans/pull/5629
Make sure CTXVALUE_CAP_DELETE is added to context value only for nodes, which can be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] thurka commented on pull request #5629: LSP: Fix Delete action in context menu
Posted by "thurka (via GitHub)" <gi...@apache.org>.
thurka commented on PR #5629:
URL: https://github.com/apache/netbeans/pull/5629#issuecomment-1463413401
I was looking at the case of Maven project and it seems to me that the behaviour is sane. Dependency node for particular jar returns true from `canDestroy()` for jars, which are not transitive dependency and implementation of `destroy()` method correctly removes such jar dependency from a project. If above behaviour is not wanted, this seems to be different issue and should be fixed as a separate bug/enhancement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5629: LSP: Fix Delete action in context menu
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5629:
URL: https://github.com/apache/netbeans/pull/5629#issuecomment-1463435093
OK. In Maven, 'Delete' on transitive dependency does not work. In Gradle, Delete is offered despite NB IDE does not have an action to remove a dependency in gradle projects - but that was the case in NB 17 as well. Tracked as #5647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5629: LSP: Fix Delete action in context menu
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5629:
URL: https://github.com/apache/netbeans/pull/5629#issuecomment-1461505920
It seems that Delete is enabled for JARs in the project: in Gradle projects, an item from a configuration, in Maven project an item in Java/Test Dependencies. In NetBeans IDE, the action is not available - and it even does not make sense, if e.g. the jar is some transitive dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #5629: LSP: Fix Delete action in context menu
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #5629:
URL: https://github.com/apache/netbeans/pull/5629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5629: LSP: Fix Delete action in context menu
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5629:
URL: https://github.com/apache/netbeans/pull/5629#issuecomment-1461513513
Seems it works the same way in NBLS 17, so let's track that as a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5629: LSP: Fix Delete action in context menu
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5629:
URL: https://github.com/apache/netbeans/pull/5629#issuecomment-1461813164
Screenshot of Delete appearing on top of jar file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists