You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/16 21:38:31 UTC

[GitHub] [iceberg] kbendick commented on pull request #5550: Spark - Add Missing Override for fileFormat function in JMH WriterBenchmark Suite

kbendick commented on PR #5550:
URL: https://github.com/apache/iceberg/pull/5550#issuecomment-1217194179

   Ok. So _not_ having the redeclaration in the subclasses doesn't work if it's declared in `IcebergSourceBenchmark`.
   
   It _is_ declared in the JMH base class in Spark 3.3 and 3.2 and 3.1.
   
   So I've added it to the highest level abstract base class, `IcebergSourceBenchmark`, for Spark 2.4 and 3.0 as well.
   
   I don't _love_ this fix, but at least it's consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org