[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1048: DISPATCH-1962 Make LSan suppressions more targeted and specific

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #1048:
URL: https://github.com/apache/qpid-dispatch/pull/1048#discussion_r581265869



##########
File path: cmake/RuntimeChecks.cmake
##########
@@ -106,9 +106,17 @@ elseif(RUNTIME_CHECK STREQUAL "asan")
     message(FATAL_ERROR "libubsan not installed - address sanitizer not available")
   endif(UBSAN_LIBRARY-NOTFOUND)
   message(STATUS "Runtime memory checker: gcc/clang address sanitizers")
+  option(SANITIZE_3RD_PARTY "Detect leaks in 3rd party libraries used by Dispatch while running tests" OFF)
+  file (COPY "${CMAKE_SOURCE_DIR}/tests/lsan.supp" DESTINATION "${CMAKE_BINARY_DIR}/tests")
+  if (NOT SANITIZE_3RD_PARTY)

Review comment:
       The flag is called SANITIZE_3RD_PARTY but it seems to be specific to libpython2.*.so  and libpython3.*.so
   Is Python really third party ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org