[GitHub] [helix] pkuwm commented on pull request #1309: Fix routingDataSourceType not configured in helix rest

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1309:
URL: https://github.com/apache/helix/pull/1309#issuecomment-679410728


   Verified it works after this change. 
   ```
   {
     "MULTI_ZK_ENABLED" : "true",
     "IS_DEFAULT" : "false",
     "MSDS_ENDPOINT" : "http://<rest-server>/admin/v2/namespaces/test",
     "NAME" : "test"
   }
   
   curl localhost:8100/admin/v2/namespaces/test/clusters                
   {
     "clusters" : [ "cluster-1", "cluster-2"]
   }
   ```
   
   The reason why we don’t catch the defect in helix rest tests is we don’t run tests against multiZk enabled. I think we should do so. We'll enable this in another PR.
   
   This PR is ready to be merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org