You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/10 10:03:22 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5987: Fix logger-plugin module directory structure problem(Maven cannot trigger junit testing).

wu-sheng commented on a change in pull request #5987:
URL: https://github.com/apache/skywalking/pull/5987#discussion_r540034393



##########
File path: CHANGES.md
##########
@@ -12,6 +12,7 @@ Release Notes.
 * The operation name of quartz-scheduler plugin, has been changed as the `quartz-scheduler/${className}` format.
 * Fix jdk-http and okhttp-3.x plugin did not overwrite the old trace header.
 * Support collecting logs of log4j, log4j2, and logback in the tracing context with a new `logger-plugin`.
+* Fix logger-plugin module directory structure problem(Maven cannot trigger junit testing).

Review comment:
       ```suggestion
   ```
   
   This fix is not related to the changelog, as the bug codes were introduced in the master only. Please remove.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org