[jira] [Commented] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

["Michael Brohl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409743#comment-16409743 ] 

Michael Brohl commented on OFBIZ-10304:
---------------------------------------

Mmhhh, Jacques, 
 
I think this is problematic because it ties a special implementation for Tomcat to the service. I didn't see this anywhere else. 
 
This issue is a bit unclear and I don't get the purpose of this change. 
 
Can you please explain more clearly which problem this changes solves and why we'll need org.apache.catalina.connector.RequestFacade as the type? 
 
Thanks, 
 
Michael

> The "request" attribute type of the userLogin service is wrong
> --------------------------------------------------------------
>
>                 Key: OFBIZ-10304
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10304
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01
>
>
> I commited http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679 which I guess forced (or allowed?) James Yong to use the javax.servlet.http.HttpServletRequest  as type of "request" attribute of the userLogin service at http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133
> Else it would (should?) have been
> <attribute name="request" mode="IN" type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to rever remove the wrapper in ContextFilter which is useless and silly (my bad).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)