You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/11/23 13:20:27 UTC
Review Request 40595: LENS-870 : Expressions in multi fact query is
not rewritten properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40595/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-870
https://issues.apache.org/jira/browse/LENS-870
Repository: lens
Description
-------
In current scenario of multifact query rewrite when any column in expression is not evaluable from candidate fact, the respective fact is removed from measure covering fact set.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 0ad7610
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 1a347b2
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java aa15a2c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 548bf5c
Diff: https://reviews.apache.org/r/40595/diff/
Testing
-------
Added new testcase. All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.829s]
[INFO] Lens .............................................. SUCCESS [2.772s]
[INFO] Lens API .......................................... SUCCESS [23.098s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.229s]
[INFO] Lens Cube ......................................... SUCCESS [5:45.717s]
[INFO] Lens DB storage ................................... SUCCESS [19.263s]
[INFO] Lens Query Library ................................ SUCCESS [16.293s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.334s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.663s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.432s]
[INFO] Lens Server ....................................... SUCCESS [8:30.511s]
[INFO] Lens client ....................................... SUCCESS [34.343s]
[INFO] Lens CLI .......................................... SUCCESS [52.892s]
[INFO] Lens Examples ..................................... SUCCESS [8.537s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.450s]
[INFO] Lens Distribution ................................. SUCCESS [9.366s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.342s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.871s]
[INFO] Lens Regression ................................... SUCCESS [13.983s]
[INFO] Lens UI ........................................... SUCCESS [27.334s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:16.188s
[INFO] Finished at: Mon Nov 23 12:16:09 UTC 2015
[INFO] Final Memory: 178M/1079M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 40595: LENS-870 : Expressions in multi fact query
is not rewritten properly
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40595/#review107578
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Nov. 23, 2015, 12:20 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40595/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 12:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-870
> https://issues.apache.org/jira/browse/LENS-870
>
>
> Repository: lens
>
>
> Description
> -------
>
> In current scenario of multifact query rewrite when any column in expression is not evaluable from candidate fact, the respective fact is removed from measure covering fact set.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 0ad7610
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 1a347b2
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java aa15a2c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 548bf5c
>
> Diff: https://reviews.apache.org/r/40595/diff/
>
>
> Testing
> -------
>
> Added new testcase. All unit tests are running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.829s]
> [INFO] Lens .............................................. SUCCESS [2.772s]
> [INFO] Lens API .......................................... SUCCESS [23.098s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.229s]
> [INFO] Lens Cube ......................................... SUCCESS [5:45.717s]
> [INFO] Lens DB storage ................................... SUCCESS [19.263s]
> [INFO] Lens Query Library ................................ SUCCESS [16.293s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.334s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.663s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.432s]
> [INFO] Lens Server ....................................... SUCCESS [8:30.511s]
> [INFO] Lens client ....................................... SUCCESS [34.343s]
> [INFO] Lens CLI .......................................... SUCCESS [52.892s]
> [INFO] Lens Examples ..................................... SUCCESS [8.537s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.450s]
> [INFO] Lens Distribution ................................. SUCCESS [9.366s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.342s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.871s]
> [INFO] Lens Regression ................................... SUCCESS [13.983s]
> [INFO] Lens UI ........................................... SUCCESS [27.334s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:16.188s
> [INFO] Finished at: Mon Nov 23 12:16:09 UTC 2015
> [INFO] Final Memory: 178M/1079M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>