[GitHub] [airflow] jedcunningham commented on a change in pull request #20881: Fix a test case inside tests/models that leaves a trace in the DB

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #20881:
URL: https://github.com/apache/airflow/pull/20881#discussion_r785161712



##########
File path: tests/models/test_dagbag.py
##########
@@ -837,6 +837,7 @@ def _sync_perms():
             mock_sync_perm_for_dag.assert_called_once_with(
                 "test_example_bash_operator", {"Public": {"can_read"}}
             )
+        delete_dag_specific_permissions()

Review comment:
       Can you look at creating a pytest fixture for this instead? Then it'll at least run if something goes wrong in this test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org