You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by aparnard <gi...@git.apache.org> on 2016/06/17 18:34:50 UTC
[GitHub] incubator-geode pull request #168: GEODE-1557: Not logging BucketNotFoundExc...
GitHub user aparnard opened a pull request:
https://github.com/apache/incubator-geode/pull/168
GEODE-1557: Not logging BucketNotFoundException
Not logging BucketNotFoundException as an error in LuceneEventLister and added
a test shouldIgnoreBucketNotFoundException to verify it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aparnard/incubator-geode feature/GEODE-1557
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 65ca0852b968e660b96446ba035736c21e88f5e6
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date: 2016-06-16T23:07:04Z
GEODE-1557: Not logging BucketNotFoundException
Not logging BucketNotFoundException as an error in LuceneEventLister and added
a test shouldIgnoreBucketNotFoundException to verify it
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #168: GEODE-1557: Not logging BucketNotFoundException
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/incubator-geode/pull/168
I was just curious as to know why manager was asked to throw a BucketNotFoundException but in the verification we are checking that logger was never called with an error method containing any exception parameter. Why is it not checking just for BucketNotFoundException but rather all Exceptions.
`verify(log, never()).error(anyString(), any(Exception.class));`
@upthewaterspout
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #168: GEODE-1557: Not logging BucketNotFoundExc...
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/168#discussion_r67784199
--- Diff: geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java ---
@@ -99,4 +105,19 @@ public void testProcessBatch() throws Exception {
verify(repo1, times(1)).commit();
verify(repo2, times(1)).commit();
}
+
+ @Test
+ public void shouldHandleBucketNotFoundExceptionWithoutLoggingError() throws BucketNotFoundException {
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #168: GEODE-1557: Not logging BucketNotFoundExc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #168: GEODE-1557: Not logging BucketNotFoundException
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/168
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---