You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jesspav (via GitHub)" <gi...@apache.org> on 2025/06/03 18:33:10 UTC

[PR] Upgrade to geotools33 [sedona]

jesspav opened a new pull request, #1967:
URL: https://github.com/apache/sedona/pull/1967

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   - No, I haven't read it.
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[SEDONA-XXX] my subject`.
   - Yes, and the PR name follows the format `[GH-XXX] my subject`.
   
   - No:
     - this is a documentation update. The PR name follows the format `[DOCS] my subject`
     - this is a CI update. The PR name follows the format `[CI] my subject`
   
   ## What changes were proposed in this PR?
   
   
   ## How was this patch tested?
   
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I am adding a new API. I am using the [current SNAPSHOT version number](https://github.com/apache/sedona/blob/99239524f17389fc4ae9548ea88756f8ea538bb9/pom.xml#L29) in `vX.Y.Z` format.
   - Yes, I have updated the documentation.
   - No, this PR does not affect any public API so no need to change the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1967:
URL: https://github.com/apache/sedona/pull/1967


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jesspav (via GitHub)" <gi...@apache.org>.
jesspav commented on code in PR #1967:
URL: https://github.com/apache/sedona/pull/1967#discussion_r2128870052


##########
examples/spark-sql/pom.xml:
##########
@@ -34,7 +34,7 @@
         <sedona.scope>compile</sedona.scope>
         <geotools.scope>compile</geotools.scope>
 
-        <geotools.version>28.2</geotools.version>

Review Comment:
   Makes sense. Will revert. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1967:
URL: https://github.com/apache/sedona/pull/1967#discussion_r2127941989


##########
examples/spark-sql/pom.xml:
##########
@@ -34,7 +34,7 @@
         <sedona.scope>compile</sedona.scope>
         <geotools.scope>compile</geotools.scope>
 
-        <geotools.version>28.2</geotools.version>
+        <geotools.version>33.1</geotools.version>

Review Comment:
   ```suggestion
           <geotools.version>28.2</geotools.version>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1967:
URL: https://github.com/apache/sedona/pull/1967#discussion_r2127941489


##########
examples/spark-sql/pom.xml:
##########
@@ -34,7 +34,7 @@
         <sedona.scope>compile</sedona.scope>
         <geotools.scope>compile</geotools.scope>
 
-        <geotools.version>28.2</geotools.version>

Review Comment:
   Let's not change the example project since it relies on a released version of Sedona



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #1967:
URL: https://github.com/apache/sedona/pull/1967#issuecomment-2944692880

   Oh right please add rc1 to the docker build. 1.8.0 is a big change so I intentionally put rc1 in geo tools-wrapper in case we need to update something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1967:
URL: https://github.com/apache/sedona/pull/1967#discussion_r2127935980


##########
.github/workflows/pyflink.yml:
##########
@@ -71,6 +71,6 @@ jobs:
       - run: uv add apache-flink==1.20.1 shapely attr setuptools
       - run: uv add pytest --dev
       - run: |
-          wget https://repo1.maven.org/maven2/org/datasyslab/geotools-wrapper/1.7.1-28.5/geotools-wrapper-1.7.1-28.5.jar
-          export SEDONA_PYFLINK_EXTRA_JARS=${PWD}/$(find flink-shaded/target -name sedona-flink*.jar),${PWD}/geotools-wrapper-1.7.1-28.5.jar
+          wget https://repo1.maven.org/maven2/org/datasyslab/geotools-wrapper/1.8.0-33.1-rc1/geotools-wrapper-1.8.0-33.1-rc1.jar
+          export SEDONA_PYFLINK_EXTRA_JARS=${PWD}/$(find flink-shaded/target -name sedona-flink*.jar),${PWD}/geotools-wrapper-1.6.0-31.0.jar

Review Comment:
   ```suggestion
             export SEDONA_PYFLINK_EXTRA_JARS=${PWD}/$(find flink-shaded/target -name sedona-flink*.jar),${PWD}/geotools-wrapper-1.8.0-33.1-rc1.jar
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jesspav (via GitHub)" <gi...@apache.org>.
jesspav commented on PR #1967:
URL: https://github.com/apache/sedona/pull/1967#issuecomment-2944357027

   Docker build is failing because of "-rc1" that was added to the new 33.1 geo wrapper name.  Do we need that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jesspav (via GitHub)" <gi...@apache.org>.
jesspav commented on code in PR #1967:
URL: https://github.com/apache/sedona/pull/1967#discussion_r2128846804


##########
.github/workflows/r.yml:
##########
@@ -56,7 +56,7 @@ jobs:
         spark: [3.4.0, 3.5.0]
         hadoop: [3]
         scala: [2.12.15]
-        r: [oldrel, release]
+        r: [oldrel]

Review Comment:
   I copied it from an old PR with the geo33 change I was following. I will revert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jesspav (via GitHub)" <gi...@apache.org>.
jesspav commented on PR #1967:
URL: https://github.com/apache/sedona/pull/1967#issuecomment-2941786937

   Note: This PR includes upgrading the download of geotools-wrapper during the pyflink .github workflow with geotools 31 since this was the most up to date version available and the workflow looks to be passing now.  [PR](https://github.com/jiayuasu/geotools-wrapper/pull/13) for creating a geotools 33 version is our for review  .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1967:
URL: https://github.com/apache/sedona/pull/1967#discussion_r2127944876


##########
.github/workflows/docker-build.yml:
##########
@@ -46,17 +46,14 @@ jobs:
       fail-fast: true
       matrix:
         os: ['ubuntu-latest']
-        spark: ['3.5.1', '3.4.3', '3.3.4']
+        spark: ['3.5.1', '3.4.3']
         include:
           - spark: 3.5.1
             sedona: 'latest'
             geotools: 'auto'
           - spark: 3.4.3
             sedona: 1.6.0
-            geotools: 28.2
-          - spark: 3.3.4
-            sedona: 1.6.0
-            geotools: 28.2
+            geotools: 33.1 

Review Comment:
   ```suggestion
               geotools: 28.2
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-1973] Upgrade to GeoTools 33 [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1967:
URL: https://github.com/apache/sedona/pull/1967#discussion_r2127942372


##########
.github/workflows/r.yml:
##########
@@ -56,7 +56,7 @@ jobs:
         spark: [3.4.0, 3.5.0]
         hadoop: [3]
         scala: [2.12.15]
-        r: [oldrel, release]
+        r: [oldrel]

Review Comment:
   Why do you remove the `release`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org