[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #6357: [INLONG-6356][Sort] Oracle connector supports precision and binary type

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #6357:
URL: https://github.com/apache/inlong/pull/6357#discussion_r1010344326


##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleReadableMetaData.java:
##########
@@ -447,16 +448,22 @@ public static Map<String, String> getOracleType(@Nullable TableChanges.TableChan
         }
         Map<String, String> oracleType = new LinkedHashMap<>();
         final Table table = tableSchema.getTable();
-        table.columns()
-                .forEach(
-                        column -> {
-                            oracleType.put(
-                                    column.name(),
-                                    String.format(
-                                            "%s(%d)",
-                                            column.typeName(),
-                                            column.length()));
-                        });
+        for (Column column : table.columns()) {
+            if (column.typeName().matches("\\w.+\\([\\d ,]+\\)")) {

Review Comment:
   It is recomment to give a reason for the handle?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org