You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/09 12:24:50 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
GabrielBrascher opened a new pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775
### Description
PR #4698 was merged at the master (4.16) but it fixes an issue that is also relevant for current LTS versions.
Considering that the port is relatively straight-forward and it can benefit releases 4.14.2.0 and 4.15.1.0, this PR proposes back-porting PR #4698 into 4.14 and later forward it to 4.15.
More details at #4698.
> In the execution flow of the API migrateVirtualMachineWithVolume, there is a step that copies the volume's template to the target storage, if it is needed.
> In some cases when the volume is a data type, it (the volume) does not have a template; therefore, it is going to generate an NPE when it tries to get the template's ID (Long to long auto conversion).
>
> This PR intends to validate if the volume being copied has a template, before trying to copy the template.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-813640496
<b>Trillian test result (tid-351)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33876 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4775-t351-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 76.30 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 53.09 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-811066532
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-801756833
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-811617906
<b>Trillian test result (tid-319)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45382 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4775-t319-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 78 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 75.76 | test_kubernetes_clusters.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
test_01_migrate_VM_and_root_volume | `Error` | 61.08 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.16 | test_vm_life_cycle.py
test_05_rvpc_multi_tiers | `Failure` | 377.07 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 402.96 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-813304372
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-797342307
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-813336853
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-811126122
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-813336540
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-793887460
@weizhouapache thanks for the review!
It was the contributor option sending the changes to the master. I have nothing against their decision. I understand and respect their point of view.
Personally, I see the benefit of porting it into 4.14.2 and 4.15.1 and thus proposed this PR.
[Here is the discussion about it with the contributor point of view.](https://github.com/apache/cloudstack/pull/4698#issuecomment-781257832)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-797352992
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 97
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-813304587
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-811125397
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-802810048
<b>[S] Trillian test result (tid-169)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 97335 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4775-t169-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 58 look OK, 25 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 263.94 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 306.80 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 128.11 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 154.89 | test_internal_lb.py
test_01_create_lb_rule_src_nat | `Failure` | 308.63 | test_loadbalance.py
test_02_create_lb_rule_non_nat | `Failure` | 35.57 | test_loadbalance.py
test_assign_and_removal_lb | `Failure` | 34.55 | test_loadbalance.py
test_01_verify_libvirt | `Error` | 602.66 | test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart | `Error` | 609.93 | test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk | `Error` | 604.88 | test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci | `Error` | 602.11 | test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart | `Error` | 608.98 | test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again | `Error` | 602.01 | test_deploy_virtio_scsi_vm.py
test_02_deploy_vm_with_extraconfig_kvm | `Error` | 632.44 | test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm | `Error` | 741.41 | test_deploy_vm_extra_config_data.py
test_01_port_fwd_on_src_nat | `Failure` | 604.98 | test_network.py
test_02_port_fwd_on_non_src_nat | `Failure` | 606.92 | test_network.py
test_reboot_router | `Failure` | 344.60 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 607.46 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 609.09 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 612.11 | test_network.py
test_isolate_network_password_server | `Failure` | 157.14 | test_password_server.py
test_01_deploy_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_02_vpc_privategw_static_routes | `Failure` | 748.04 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 744.94 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 878.76 | test_privategw_acl.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.01 | test_kubernetes_supported_versions.py
test_router_dhcphosts | `Failure` | 156.96 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 168.24 | test_router_dhcphosts.py
test_router_dhcp_opts | `Error` | 609.07 | test_router_dhcphosts.py
test_router_dns_guestipquery | `Failure` | 454.55 | test_router_dns.py
test_router_dns_guestipquery | `Failure` | 455.07 | test_router_dnsservice.py
test_02_routervm_iptables_policies | `Error` | 654.35 | test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies | `Error` | 717.10 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 203.61 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 203.72 | test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 233.93 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 229.76 | test_routers_network_ops.py
test_03_RVR_Network_check_router_state | `Error` | 676.79 | test_routers_network_ops.py
test_01_router_internal_basic | `Error` | 602.76 | test_routers.py
test_02_router_internal_adv | `Error` | 602.76 | test_routers.py
test_04_restart_network_wo_cleanup | `Error` | 604.98 | test_routers.py
test_01_service_offering_cpu_limit_use | `Error` | 100.50 | test_service_offerings.py
test_04_change_offering_small | `Failure` | 715.01 | test_service_offerings.py
test_01_snapshot_root_disk | `Error` | 606.01 | test_snapshots.py
test_03_ssvm_internals | `Error` | 602.71 | test_ssvm.py
test_04_cpvm_internals | `Error` | 602.78 | test_ssvm.py
test_05_stop_ssvm | `Error` | 646.21 | test_ssvm.py
test_06_stop_cpvm | `Error` | 658.38 | test_ssvm.py
test_07_reboot_ssvm | `Error` | 624.05 | test_ssvm.py
test_08_reboot_cpvm | `Error` | 621.03 | test_ssvm.py
test_09_destroy_ssvm | `Error` | 654.32 | test_ssvm.py
test_10_destroy_cpvm | `Error` | 650.23 | test_ssvm.py
test_01_migrate_VM_and_root_volume | `Error` | 61.05 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.06 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 695.15 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 637.25 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 637.09 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 637.11 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | `Failure` | 607.67 | test_vm_life_cycle.py
test_01_create_vm_snapshots | `Failure` | 607.48 | test_vm_snapshots.py
test_02_revert_vm_snapshots | `Failure` | 601.32 | test_vm_snapshots.py
test_03_delete_vm_snapshots | `Failure` | 0.02 | test_vm_snapshots.py
test_01_create_volume | `Failure` | 608.72 | test_volumes.py
test_02_attach_volume | `Failure` | 605.53 | test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 817.83 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Error` | 819.10 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 735.10 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 698.71 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 792.03 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 818.93 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 718.12 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Failure` | 716.09 | test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 322.41 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 235.97 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 272.65 | test_vpc_vpn.py
test_hostha_enable_ha_when_host_disabled | `Error` | 4.45 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected | `Error` | 603.08 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.54 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-802810048
<b>[S] Trillian test result (tid-169)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 97335 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4775-t169-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 58 look OK, 25 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 263.94 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 306.80 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 128.11 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 154.89 | test_internal_lb.py
test_01_create_lb_rule_src_nat | `Failure` | 308.63 | test_loadbalance.py
test_02_create_lb_rule_non_nat | `Failure` | 35.57 | test_loadbalance.py
test_assign_and_removal_lb | `Failure` | 34.55 | test_loadbalance.py
test_01_verify_libvirt | `Error` | 602.66 | test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart | `Error` | 609.93 | test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk | `Error` | 604.88 | test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci | `Error` | 602.11 | test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart | `Error` | 608.98 | test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again | `Error` | 602.01 | test_deploy_virtio_scsi_vm.py
test_02_deploy_vm_with_extraconfig_kvm | `Error` | 632.44 | test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm | `Error` | 741.41 | test_deploy_vm_extra_config_data.py
test_01_port_fwd_on_src_nat | `Failure` | 604.98 | test_network.py
test_02_port_fwd_on_non_src_nat | `Failure` | 606.92 | test_network.py
test_reboot_router | `Failure` | 344.60 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 607.46 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 609.09 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 612.11 | test_network.py
test_isolate_network_password_server | `Failure` | 157.14 | test_password_server.py
test_01_deploy_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_02_vpc_privategw_static_routes | `Failure` | 748.04 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 744.94 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 878.76 | test_privategw_acl.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.01 | test_kubernetes_supported_versions.py
test_router_dhcphosts | `Failure` | 156.96 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 168.24 | test_router_dhcphosts.py
test_router_dhcp_opts | `Error` | 609.07 | test_router_dhcphosts.py
test_router_dns_guestipquery | `Failure` | 454.55 | test_router_dns.py
test_router_dns_guestipquery | `Failure` | 455.07 | test_router_dnsservice.py
test_02_routervm_iptables_policies | `Error` | 654.35 | test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies | `Error` | 717.10 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 203.61 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 203.72 | test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 233.93 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 229.76 | test_routers_network_ops.py
test_03_RVR_Network_check_router_state | `Error` | 676.79 | test_routers_network_ops.py
test_01_router_internal_basic | `Error` | 602.76 | test_routers.py
test_02_router_internal_adv | `Error` | 602.76 | test_routers.py
test_04_restart_network_wo_cleanup | `Error` | 604.98 | test_routers.py
test_01_service_offering_cpu_limit_use | `Error` | 100.50 | test_service_offerings.py
test_04_change_offering_small | `Failure` | 715.01 | test_service_offerings.py
test_01_snapshot_root_disk | `Error` | 606.01 | test_snapshots.py
test_03_ssvm_internals | `Error` | 602.71 | test_ssvm.py
test_04_cpvm_internals | `Error` | 602.78 | test_ssvm.py
test_05_stop_ssvm | `Error` | 646.21 | test_ssvm.py
test_06_stop_cpvm | `Error` | 658.38 | test_ssvm.py
test_07_reboot_ssvm | `Error` | 624.05 | test_ssvm.py
test_08_reboot_cpvm | `Error` | 621.03 | test_ssvm.py
test_09_destroy_ssvm | `Error` | 654.32 | test_ssvm.py
test_10_destroy_cpvm | `Error` | 650.23 | test_ssvm.py
test_01_migrate_VM_and_root_volume | `Error` | 61.05 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.06 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 695.15 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 637.25 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 637.09 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 637.11 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | `Failure` | 607.67 | test_vm_life_cycle.py
test_01_create_vm_snapshots | `Failure` | 607.48 | test_vm_snapshots.py
test_02_revert_vm_snapshots | `Failure` | 601.32 | test_vm_snapshots.py
test_03_delete_vm_snapshots | `Failure` | 0.02 | test_vm_snapshots.py
test_01_create_volume | `Failure` | 608.72 | test_volumes.py
test_02_attach_volume | `Failure` | 605.53 | test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 817.83 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Error` | 819.10 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 735.10 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 698.71 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 792.03 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 818.93 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 718.12 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Failure` | 716.09 | test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 322.41 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 235.97 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 272.65 | test_vpc_vpn.py
test_hostha_enable_ha_when_host_disabled | `Error` | 4.45 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected | `Error` | 603.08 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.54 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-797341868
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-811067301
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-793927366
> @weizhouapache thanks for the review!
>
> It was the contributor option sending the changes to the master. I have nothing against their decision. I understand and respect their point of view.
>
> Personally, I see the benefit of porting it into 4.14.2 and 4.15.1 and thus proposed this PR.
>
> [Here is the discussion about it with the contributor point of view.](https://github.com/apache/cloudstack/pull/4698#issuecomment-781257832)
@GabrielBrascher thanks for your explanation.
sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-811079571
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: debian. SL-JID 300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-801756605
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-813331470
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: debian. SL-JID 324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org