You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/02 19:43:15 UTC

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1180: libc: Remove the up_romgetc support from fgets

patacongo edited a comment on pull request #1180:
URL: https://github.com/apache/incubator-nuttx/pull/1180#issuecomment-637763581


   This function did not need to be decorated with IPTR since it explicitly copied the bytes from ROM.  IPTR is a special storage class for Harvard architecture maches that indicates that the pointed to data resides in instruction (ROM) space.  In this case, it would instead explicitly copy from instruction space.
   
   This function is older than IPTR.  If you are going to remove this function, then could you please add IPTR to the string pointer argument?  Currrently, the copy from ROM, either explicitly as here or implicitly using IPTR is required for all AVR builds.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org