You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Cartereau (Jira)" <ji...@apache.org> on 2019/10/21 15:42:00 UTC
[jira] [Created] (MSHADE-332) Add a log when original artifact
already exist and is not replaced
Benjamin Cartereau created MSHADE-332:
-----------------------------------------
Summary: Add a log when original artifact already exist and is not replaced
Key: MSHADE-332
URL: https://issues.apache.org/jira/browse/MSHADE-332
Project: Maven Shade Plugin
Issue Type: Improvement
Affects Versions: 3.2.1
Reporter: Benjamin Cartereau
When using the plugin (defaut config, just include a dependency) to build a project (mvn clean package), I end up having :
* original-xxxx.jar
* xxxx.jar (the shaded uber jar)
If I do a 2nd build (mvn package) without a clean, I end up having :
* original-xxxx.jar
* xxxx.jar (the shaded uber jar)
* xxxx-shaded.jar (the shaded uber jar too)
I don't know if it is the expected behavior. _In my case I was then using the assembly plugin and in some case (not doing a clean before a build) I did include the xxxx-shaded.jar artefact and it was not the expected behavior to me. So it is not excluded from my assembly descriptor._
But at least it would be great to have a log that says the shaded artifact will not be deleted.
If I am right, it is happening after the log message that says "Replacing original artifact with shaded artifact."
And, in fact, it is not always "replaced":
https://github.com/apache/maven-shade-plugin/blob/maven-shade-plugin-3.2.1/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java#L512
Thanks
--
This message was sent by Atlassian Jira
(v8.3.4#803005)